Fairly straightforward patch... there are a number of ctools JS functions and statements missing semicolons.

To be consistent and ensure there are no issues when aggregating or compressing JavaScript, these semicolons should be included.

Please see the attached patch, thanks.

CommentFileSizeAuthor
#4 3057409-4-interdiff.patch1.64 KBjoelpittet
ctools-missing_js_semicolons-1.patch6.09 KBsgdev

Comments

ron_s created an issue. See original summary.

sgdev’s picture

sgdev commented

This patch still applies cleanly to 7.x-1.17.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

I was about to commit this @ron_s but noticed some semi-colons at the bottoms of the scripts around for example

Drupal.behaviors.CToolsColorSettings = {..} in js/stylizer.js

Any reason for the omission for these? I was going to fix on commit but maybe there was a reason for that...

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed
StatusFileSize
new 3057409-4-interdiff.patch1.64 KB

Here's the additional ones, I'm committing this all to dev thanks @ron_s

  • joelpittet committed d5dc383 on 7.x-1.x authored by ron_s 
    Issue #3057409 by ron_s, joelpittet: Missing JS semicolons
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: » #3178697: Plan for CTools 7.x-1.18 release
sgdev’s picture

sgdev commented

Hello, sorry I never responded to your previous message. The only reason for the omission is they are technically considered unnecessary since they are followed by the end of the jQuery function. For sake of completeness it's certainly fine to include them too.

Thanks for your help!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

No worries, I kinda guessed that was the case. Thank you for the patch @ron_s

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.