When an $element exists, the #attached array should be used to include JavaScript and CSS. Otherwise, there is a possibility of pages loading as broken when JS aggregation or Ajax modal windows are used.

The included patch resolves this by replacing each drupal_add_js and drupal_add_library with its proper code for #attached.

The one place I did not modify drupal_add_js is in ajax_facets_views_pre_render, which I will address in a separate issue.

Please review, thanks.

CommentFileSizeAuthor
#5 interdiff-3057269-1-5.txt339 bytessgdev
#5 ajax_facets-attach_js_to_elements-3057269-5.patch4.7 KBsgdev
ajax_facets-attach_js_to_elements-1.patch4.7 KBsgdev

Comments

ron_s created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

this change should go in please.

narkoff’s picture

narkoff commented

Successfully tested patch #1, no issues.

i.koychev’s picture

i.koychev commented

The patch works for me after changing the
$element['#attached']['library'] = array('system', 'drupal.ajax');
with
$element['#attached']['library'][] = array('system', 'drupal.ajax');
Otherwise an error occurs: Uncaught TypeError: Drupal.ajax is not a constructor.

sgdev’s picture

sgdev commented
StatusFileSize
new ajax_facets-attach_js_to_elements-3057269-5.patch4.7 KB
new interdiff-3057269-1-5.txt339 bytes

Thanks, that's a fine change to make. Updated patch and interdiff are attached.