Drupal 9 compatibility issues, I will post a patch if someone doesn't beat me to it :)

drupal-check -ad web/modules/contrib/rrssb
11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------
Line includes/rrssb.drush.inc
------ -----------------------------------------------------------------------
13 Function rrssb_drush_command not found while trying to analyse it -
autoloading is probably not configured properly.
31 Function rrssb_drush_help not found while trying to analyse it -
autoloading is probably not configured properly.
41 Function drush_rrssb_post_pm_enable not found while trying to analyse
it - autoloading is probably not configured properly.
44 Function drush_rrssb_plugin not found.
51 Function drush_rrssb_plugin not found while trying to analyse it -
autoloading is probably not configured properly.
62 Call to deprecated function drush_log().
63 Call to deprecated function drush_delete_dir().
74 Function drush_download_file not found.
79 Function drush_tarball_extract not found.
92 Function drush_move_dir not found.
98 Call to deprecated function drush_log().
104 Function drush_rrssb_gen_css not found while trying to analyse it -
autoloading is probably not configured properly.
------ -----------------------------------------------------------------------

------ ------------------------------------------------------------
Line rrssb.install
------ ------------------------------------------------------------
85 Call to deprecated method entityManager() of class Drupal.
------ ------------------------------------------------------------

------ -----------------------------------------------------------------
Line rrssb.module
------ -----------------------------------------------------------------
180 Variable $rrssb might not be defined.
278 Variable $buttons in isset() always exists and is not nullable.
------ -----------------------------------------------------------------

------ ---------------------------------------------------
Line src/Form/RRSSBDeleteForm.php
------ ---------------------------------------------------
42 Call to deprecated function drupal_set_message().
------ ---------------------------------------------------

------ ----------------------------------------------------
Line src/Form/RRSSBSettingsForm.php
------ ----------------------------------------------------
24 Access to an undefined property
Drupal\rrssb\Form\RRSSBSettingsForm::$entityQuery.
266 Access to an undefined property
Drupal\rrssb\Form\RRSSBSettingsForm::$entityQuery.
------ ----------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Plugin/Block/RRSSBBlock.php
------ ----------------------------------------------------------------------
25 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------

CommentFileSizeAuthor
#7 deprecated-3057221-7.patch1.41 KBsergiu stici
#3 rrssb.drupal.9-3057221-3.patch2.57 KBadamps

Comments

ikit-claw created an issue. See original summary.

goyalsushant’s picture

goyalsushant commented
adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new rrssb.drupal.9-3057221-3.patch2.57 KB

I have just created an automatic test and this patch fixes the deprecation problems that prevent it from running cleanly. It will not fix everything - we can do a second commit later.

Status: Needs review » Needs work

The last submitted patch, 3: rrssb.drupal.9-3057221-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • AdamPS committed e722f53 on 8.x-2.x 
    Issue #3057221 by AdamPS: Drupal 9 compatibility
adamps’s picture

adamps commented
Status: Needs work » Active
sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3057221-7.patch1.41 KB 
php drupal-check.phar modules/contrib/rrssb/
 12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------- 
  Line   rrssb.install                                                   
 ------ ---------------------------------------------------------------- 
  85     Call to deprecated method entityManager() of class Drupal.      
  112    Call to deprecated function file_unmanaged_delete_recursive().  
 ------ ---------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/RRSSBDeleteForm.php                       
 ------ --------------------------------------------------- 
  42     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors

I found a few deprecated function.
Here is the patch, please review.

adamps’s picture

adamps commented
Status: Needs review » Fixed

Great thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.