Drupal 9 compatibility report: will submit a patch if someone doesn't beat me to it :)

drupal-check -ad web/modules/contrib/google_tag
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------------
Line google_tag.install
------ --------------------------------------------------
21 Call to deprecated method url() of class Drupal.
------ --------------------------------------------------

------ -----------------------------------------------------------------
Line google_tag.module
------ -----------------------------------------------------------------
199 Call to deprecated function drupal_set_message().
232 Call to deprecated function drupal_set_message().
233 Call to deprecated function drupal_set_message().
251 Call to deprecated method strtolower() of class
Drupal\Component\Utility\Unicode.
264 Call to deprecated method strtolower() of class
Drupal\Component\Utility\Unicode.
268 Call to deprecated function drupal_set_message().
298 Call to deprecated function drupal_set_message().
311 Call to deprecated function file_stream_wrapper_valid_scheme().
321 Call to deprecated function drupal_mkdir().
328 Call to deprecated function drupal_chmod().
------ -----------------------------------------------------------------

------ -------------------------------------------------------------------------
Line includes/snippet.inc
------ -------------------------------------------------------------------------
17 Function google_tag_snippets not found while trying to analyse it -
autoloading is probably not configured properly.
19 Function _google_tag_script_snippet not found.
20 Function _google_tag_noscript_snippet not found.
21 Function _google_tag_data_layer_snippet not found.
34 Function _google_tag_script_snippet not found while trying to analyse
it - autoloading is probably not configured properly.
37 Function _google_tag_variable_clean not found.
38 Function _google_tag_variable_clean not found.
39 Function _google_tag_environment_query not found.
76 Function _google_tag_noscript_snippet not found while trying to analyse
it - autoloading is probably not configured properly.
79 Function _google_tag_variable_clean not found.
80 Function _google_tag_environment_query not found.
109 Function _google_tag_data_layer_snippet not found while trying to
analyse it - autoloading is probably not configured properly.
112 Function _google_tag_variable_clean not found.
139 Function _google_tag_environment_query not found while trying to
analyse it - autoloading is probably not configured properly.
146 Function _google_tag_variable_clean not found.
147 Function _google_tag_variable_clean not found.
162 Function _google_tag_variable_clean not found while trying to analyse
it - autoloading is probably not configured properly.
------ -------------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Form/GoogleTagSettingsForm.php
------ ----------------------------------------------------------------------
365 \Drupal calls should be avoided in classes, use dependency injection
instead
380 Function google_tag_snippets not found.
389 \Drupal calls should be avoided in classes, use dependency injection
instead
394 \Drupal calls should be avoided in classes, use dependency injection
instead
429 Call to deprecated function drupal_set_message().
------ ----------------------------------------------------------------------

CommentFileSizeAuthor
#2 d9_compatibility-3057215-2.patch13.32 KBsergiu stici

Comments

ikit-claw created an issue. See original summary.

sergiu stici’s picture

Status: Active » Needs review
StatusFileSize
new13.32 KB

Here is the patch, please review.

  • solotandem committed 28fed19 on 8.x-1.x
    Issue #3057215 by Sergiu Stici, solotandem: Replace deprecated routines...
solotandem’s picture

Version: 8.x-1.1 » 8.x-1.x-dev
Assigned: Unassigned » solotandem
Status: Needs review » Fixed

Commit

  • replaces deprecated routines and constants
  • injects more services to ContainerManager class
  • leaves only 4 items in the drupal-check review

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.