There are a few coding standard errors after the recent commits.

CommentFileSizeAuthor
#2 entity-embed-standard-fixes-3057026-2.patch1.75 KBoknate

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-embed-standard-fixes-3057026-2.patch1.75 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

There's one still left, shall we do that one too?

src/Form/EntityEmbedDialog.php ✓ 3 fewer
line 877	Public method name "EntityEmbedDialog::registerJSCallback" is not in lowerCamel format
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Minor coding issues » Minor coding standards issues
oknate’s picture

oknate
Location Greater New York City Area
commented

I think maybe we should leave that one, in case someone is extending EntityEmbedDialog and overriding either buildSelectStep or registerJSCallback, but not both. It breaks backwards compatibility to change the name of the method, unfortunately.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Right. I was considering to break it to comply with coding standards, but that’s of course less important than BC.

RTBC!

  • Wim Leers committed 9bf58b8 on 8.x-1.x authored by oknate 
    Issue #3057026 by oknate: Minor coding standards issues
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

🚢

oknate’s picture

oknate
Location Greater New York City Area
commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.