Hi everyone.
The order activity logs are submitted when the pre transition event of the order state is fired. This might lead to incorrect logging in cases where something goes wrong while saving the order. To eliminate the possibility of logging the transition, without the transition being actually complete, if an error occurs in between the two actions i would recommend changing the event listener to the post transition event.
If there is a logic behind using the pre transition event please let me know.
I thank you in advance.
Edit: I supplied the above mentioned patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | activity-log-transition-3056862-2.patch | 1.15 KB | marios anagnostopoulos |
Comments
Comment #2
marios anagnostopoulos commentedComment #3
marios anagnostopoulos commentedComment #4
marios anagnostopoulos commentedSorry For the previous patches that could not be applied.
Comment #6
bojanz commentedI can see the logic in that, why not. Committed, and removed the priorities along the way (since they don't feel useful with a post_transition event, it's fine to log stuff before the other event subscribers trigger).