The scripts should implement Drupal.t() so that the strings are possible to translate.

CommentFileSizeAuthor
#3 webpush-js-scripts-should-be-wrapped-in-Drupal-t-to-be-translatable-3056733-3.patch9.91 KBsvenryen
#2 webpush-js-scripts-should-be-wrapped-in-Drupal-t-to-be-translatable-3056733-2.patch4.76 KBsvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new webpush-js-scripts-should-be-wrapped-in-Drupal-t-to-be-translatable-3056733-2.patch4.76 KB

Attaching proposed patch that wraps all js user interface strings and notifications in Drupal.t().

svenryen’s picture

svenryen commented
StatusFileSize
new webpush-js-scripts-should-be-wrapped-in-Drupal-t-to-be-translatable-3056733-3.patch9.91 KB

Updated patch that has the compiled js file as well.

svenryen’s picture

svenryen commented
Status: Active » Needs review

  • efpapado committed a619403 on 7.x-1.x authored by svenryen 
    Issue #3056733 by svenryen: JS scripts should be wrapped in Drupal.t()...
efpapado’s picture

efpapado commented
Status: Needs review » Fixed

Thanks, committed :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.