I came across /admin/structure/views and saw that the view names in that list are visually way too big in my opinion (they are even bigger than the list headline 'view name' row headline). It's a h3 causing that issue. See screenshot attached.
Should we change this or is that intended?
How should it look like?
I would suggest that it should look like the block region name here /admin/structure/block
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 3056395-interdiff-6-15.txt | 548 bytes | thamas |
| #15 | claro-resize-view-names-on-views-list-3056395-15.patch | 1.87 KB | thamas |
| #6 | 3056395-6.claro_.resize-view-names-on-view-list.patch | 1.77 KB | fhaeberle |
Comments
Comment #2
fhaeberleComment #3
fhaeberleComment #4
quironI went through all the figma document and I don't find a reference to a similar layout. So marking it as Needs design.
Comment #5
huzookaIssue does not have patches, let's change it to Active.
Comment #6
fhaeberleDoing some research on this, I found out that the h3 causing the big text rendering is default layout in core. The specific file can be found under:
core/themes/stable/templates/admin/views-ui-views-listing-table.html.twigI altered this template file and added it to our own admin folder - it works, but I don't know if that's the correct way here.
Should we open an issue for that in core and try to fix it there? Ideas appreciated.
Changes in this patch:
- adding altered views ui template
Comment #7
fhaeberleComment #8
lauriiiI think at least visually it would make sense to make this change. This does change the structure, but since we don't use h3 for the key columns of other tables such as the node table, I think this should be fine. This happens in Seven as well, so I think we should open an issue for this in core. We should also add a todo to whatever workaround we create here to remove it after the upstream bug has been fixed.
Comment #9
anevins commentedI side with changing this from using a H3 (or a heading at all) because it is structured in a table and that's where the meaning is.
Comment #10
fhaeberle@laurriii I'm going to open an issue for that in core and try to fix it there.
@anevins For sure. Thanks for your thoughts.
Comment #11
fhaeberleComment #12
huzookaComment #13
thamasTested manually, the patch from #6 and it works well.
What we may miss yet is to add a todo to remove this template when the related core issue is fixed as Laurii suggested it in #8. I do not know where that todo should be written.
Comment #14
lauriiiI think adding a todo message is a great suggestion @thamas! We could add that in the @file docblock after the @see. We should link it to the Drupal Core issue so it can be tracked.
Comment #15
thamasLaurii I'm glad you like it because it was your idea to add a @todo! :D
Thanks for guiding about where it should have been added!
Comment #16
fhaeberleLooks good! From my point of view RTBC :)
Comment #18
lauriiiThis is a nice improvement! Thank you folks!