Problem/Motivation

Resizing a window in \Drupal\Tests\layout_builder\FunctionalJavascript\BlockFormMessagesTest::testValidationMessage() appears to fix a random fail.

Looking at the html again - we have a Placeholder for the "New title" block but we're expecting the block to have been replaced real block and be identified by #layout-builder .block-system-powered-by-block

Proposed resolution

For whatever reason, the screen resize isn't necessary anymore and the test doesn't have random failures without it.

Let's remove the resize so the test is inline with (almost) every other FunctionalJavascript test.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Needs review » Postponed
krzysztof domański’s picture

Status: Postponed » Active

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

spokje’s picture

Assigned: Unassigned » spokje
Issue summary: View changes
StatusFileSize
new2.84 KB

I believe the screen resizing isn't necessary anymore.

The normal routine to prove a random failure is fixed is to run the failing patch and the patch with the fix at the same time, whilst the latter has to have ~5000-8000 failure free runs to prove it's credibility.

Since this issue is a bit different, there is no failing test, we can "just" run the patch without the screen resize and see if it has ~8000 - 10.000 failure free runs

So let's do that here.

spokje’s picture

StatusFileSize
new2.84 KB

Ok...

5000x seems a bit too much, after we hit around 45 minutes in the test run, things go "wonky".
Let's see what 3000x brings us

spokje’s picture

StatusFileSize
new847 bytes

11 * 3000 = 33.000 runs without a failure.
Good enough for me, here's the actual patch.

spokje’s picture

Title: Discover why resizing window fixes random fail in BlockFormMessagesTest::testValidationMessage » Remove resizing window in BlockFormMessagesTest::testValidationMessage
spokje’s picture

Assigned: spokje » Unassigned
Status: Active » Needs review
borisson_’s picture

Status: Needs review » Reviewed & tested by the community

I believe the screen resizing isn't necessary anymore.

This issue is to figure out why this line was making the test pass, but something in the meanwhile has made this no longer needed. The patch in #14 looks great. I would love to know why but I think we can commit this as-is.

  • longwave committed c61764be on 11.x
    Issue #3055982 by Spokje, alexpott: Remove resizing window in...
longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed c61764b and pushed to 11.x. Thanks!

Wary of backporting things that might cause random fails, it's not hurting anything so let's put this in 11.x only.

longwave’s picture

Issue tags: +ddd2023

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.