What for

This module provides a block that display feeds from any social network.
New social networks and the way they are displayed can be implemented in your module.

Available configurations :

  • Which social networks to display
  • Social networks order
  • Any configuration you set in your custom social network (number of posts to show, ...)
  • New permission Administer social networks

Usage

Configure each social networks (API data, number of posts, etc...) on Configuration > Web services > Social networks.
Add the Social wall block to the page you want, and configure social networks in its configuration.

Project link

https://www.drupal.org/project/social_wall

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/social_wall.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-social_wall.git

Comments

NicociN created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for your contribution! I added the Git instructions for non-maintainer users and the PAReview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

avpaderno’s picture

Status: Needs review » Needs work

The code must be pushed in a branch that is not master, which needs to be removed. Release naming conventions describes the branch names to use on drupal.org.

nicocin’s picture

Status: Needs work » Needs review

Hi, thanks for your fast answer.
The branching is fixed, also coding standards.

klausi’s picture

Issue summary: View changes
avpaderno’s picture

Issue summary: View changes

(Now I added the PAReview checklist link.)

cristian100’s picture

Hi Nicolas, thanks a lot for your contribution, social walls are often needed in Drupal Websites.

One review I can make is on the module info file, name of the module should be capital, because module names are proper nouns.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

So instead of:
name: 'Social wall'

Could be changed to:
name: 'Social Wall'

I have created a ticket in the Project page with a patch to fix this:
https://www.drupal.org/project/social_wall/issues/3057926#comment-13125940

Thanks,

klausi’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for your contribution!

All looking good to me.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

nicocin’s picture

Thanks @cristian100 for your feedback.
Issue fixed.
And thanks to all reviewers !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nicocin’s picture

Hello @kiamlaluno, the module is still not covered by Drupal’s security advisory policy, while this ticket has been closed & module has been reviewed & tested by the community. Is it normal ?

avpaderno’s picture

You need to edit the project, to opt into security coverage.

nicocin’s picture

Yayyyyy !
Thank you :)