The tome:import command deletes all content before running an import, but does this without batching which means that it can't scale. We should spawn sub-commands just like we do with the "tome:import-content" command.

CommentFileSizeAuthor
#2 3055688-2.patch7.9 KBsamuel.mortenson

Comments

samuel.mortenson created an issue. See original summary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3055688-2.patch7.9 KB

Moved deletions to sub-processes and made it so that notices thrown in sub-processes do not cause parent commands to fail. There must have been a reason I was checking error output as something more authoritative than real process failures but I'm not sure now.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Haven't tested it thoroughly, but code looks good to me. Thanks!

  • samuel.mortenson authored 27926bc on 8.x-1.x 
    Issue #3055688 by samuel.mortenson, plopesc: Content deletion in import...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review! I'll test out the dev branch on a few projects now to see if this breaks anything.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.