Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 May 2019 at 09:55 UTC
Updated:
16 Jan 2020 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nikolas.tatianenko commentedComment #3
nikolas.tatianenko commentedComment #4
nikolas.tatianenko commentedChanges needs review
Comment #6
jonathan1055 commentedThanks for the patch. Can I suggest that, instead of trying to fix a whole set of test files in one patch, you focus on just one type of deprecation and replacement. This will make testing and reviewing easier, and we can commit smaller patches.
Also with just one deprecation per issue, can you add a link to the Change Record and/or documentation page in the issue summary, so that we can see what is being fixed. Your patch altered 18 test files and the four tests which failed are
Good start though. Splitting up the issue will help to make progress on this.
Jonathan
Comment #7
jonathan1055 commentedAnother reason for splitting out into separate issues for each problem is that you avoid repeating other people's work. In your patch you have included changes for
assertText()but this has already been started in #3050086: Replace deprecated function assertText() with pageTextContains()Comment #8
jonathan1055 commentedAfter checking all the changes made in patch #3 a large proportion are now covered by other issues. After removing all those, the majority of what was left were replacing
assertResponse()withassertSession()->statusCodeEquals(). Hence this issue can now be specifically for that fix.Comment #10
jonathan1055 commentedDone.
Comment #11
jonathan1055 commentedThe second parameter is not required in
statusCodeEqual()and should be removed.Can also use
$assert()when #3102092: Replace deprecated function assertNoText() with pageTextNotContains() is committed.Comment #12
jonathan1055 commentedPatch for checking.
Comment #14
jonathan1055 commentedDone.