It would be great to be able to set placeholder text in the search box per field. I have made a patch that adds a section on the settings form for placeholder text that will show on every field. I will attach it in the next comment so I can get the issue number for the filename.

Comments

genellann created an issue. See original summary.

genellann’s picture

dmitrii’s picture

Version: 8.x-1.3 » 8.x-1.x-dev
Status: Active » Needs work

Thank you for the patch. I like the idea.
Patch needs to be rerolled against 8.x-1.x

dmitrii’s picture

Issue tags: +DrupalCampBelarus2019
tatarbj’s picture

Assigned: Unassigned » tatarbj

I'm going to reroll and if needed adjust the solution today at Contribution Day of DrupalCamp Belarus!

zeuty’s picture

Rerolled against 8.x-1.x

tatarbj’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
zeuty’s picture

Adjusted the .schema file to include the new field.

zeuty’s picture

Status: Needs work » Needs review
dmitrii’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new159.5 KB
new94.62 KB

The patch tested locally (Acquia dev desktop, drupal-8-7-0-beta1, Chrome Version 74.0.3729.157 (Official Build) (64-bit))
Looks good, no FE or BE errors found.
Edit node form:
Edit
The module setting form:
Settings

  • dmitrii committed d90cb72 on 8.x-1.x authored by zeuty
    Issue #3055587 by zeuty, genellann, dmitrii, tatarbj: Placeholder text...
dmitrii’s picture

Status: Reviewed & tested by the community » Fixed

  • dmitrii committed 1228ad5 on 8.x-1.x
    Address phpcs issues introduced by #2828612 and #3055587
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drup16’s picture

I did not find this issue before so I created one similar to this (Descriptive placeholder for Search is missing). It took a slightly different approach but since this issue has already been merged, I am going to close mine as a duplicate and linked the two in case anyone comes across my issue.