Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 May 2019 at 13:51 UTC
Updated:
1 Jun 2019 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jonathan1055 commentedTrial patch for drupalci.yml
Comment #3
jonathan1055 commentedThat worked! Now to really test it with a modified file which should have some coding standards faults.
Comment #4
jonathan1055 commentedPHPCS was still 8.3.2 - it was not reloaded, I guess the patch to drupal's composer.json was executed too late to be effective.
Try another way, by specifying the coder version directly in our drupalci.yml
Comment #5
jonathan1055 commentedThat did not make any difference. Try modifying composer.json
Comment #7
jonathan1055 commentedyes, that same old problem. But at least PHPCS worked this time.
Comment #9
jonathan1055 commentedThe travis tests now pass at core 8.8
https://travis-ci.org/jonathan1055/scheduler/builds/534136964
The patch https://www.drupal.org/files/issues/2019-04-22/3049433-8.patch is applied to core composer.json and composer.lock after cloning drupal but before running composer self-update and install.
Comment #10
jonathan1055 commentedPatch without changes to drupalci.yml just composer. Checking syntax ">=8.3.3"
Comment #11
jonathan1055 commentedThat's good, all as expected. The initial version loaded is:
But after the patch is applied we get:
Comment #13
jonathan1055 commentedCommitted before the re-test had run, so patch failed to apply, but all OK.
Comment #14
jonathan1055 commentedGood. We now have PHPCS running properly on our contrib patches at core 8.8.x in both drupal testing and travis build testing.