Closed (fixed)
Project:
Claro
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 May 2019 at 13:13 UTC
Updated:
12 Jun 2019 at 13:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ajitsCorrecting title. Apologies in advance if this is not correct!
Comment #3
fhaeberleNo it's not correct. I mean the text doesn't wrap / break the line. but you're right - a bit confusing, changed the title.
Comment #4
idebr commentedSetting status to 'Active', since the issue has no patch file attached. See the issue queue handbook.
Comment #5
fhaeberleAs we are working with tables here,
text-overflow: ellipsisisn't working like intended. Tried a few things withtable-layout: fixedanddisplay: blockto make it worked but failed. Also, settingmin-widthormax-widthwould mean hacking the table and would not be a good approach – but also tried that without getting it to work. In order to fix the broken layout which gets generated based on the too much width taking table (caused by the description text) I would suggest removingwhite-space: nowrapandtext-overflow:ellipsis. I provide an patch for that.Comment #6
fhaeberleComment #7
mahenkvyas22 commentedjust change .system-modules details class property white-space: nowrap; to white-space: normal; and its working fine.This css system-admin--modules.css file.
Comment #8
fhaeberle@Mahenkvyas22 Can you provide a screenshot? It's not working on latest Chrome/Firefox/Safari on my site with correct generating ellipsis but cut's the text and wraps it into a new line. I want to achieve adding the ellipsis but I think that's not possible with only CSS so we have to remove both the
text-overflowand thewhite-spaceproperty. Settingwhite-space: normalisn't nessesary because that's the default so we can get rid of the property.Comment #9
mahenkvyas22 commented@fhaeberle this is screenshot of module page.
Comment #10
fhaeberle@Mahenkvyas22 Alright, as I suggested before you also only could get it work with the simple
overflow: hiddenand no ... ellipsis. Your screenshots doesn't fix the code like it's intended to work. Sotext-overflowandwhite-spacecan completely be removed as we could not get ellipsis ... to work.Comment #11
fhaeberleThis patch should provide a fix for the too long module descriptions resulting broken layout.
Comment #12
fhaeberleComment #13
huzookaWhat if we just let the summary text overflow and break in so many lines as it needs?
Hiding text is a bad practice for accessibility reasons and this fix is only temporary imho.
Comment #14
fhaeberle@huzooka. You are right. If we wrap the text in two (or even more) lines, it has to be tested if it works with the current table layout. We have to think about edge cases like really long descriptions too (like 3 or 4 lines).
Comment #15
huzooka@fhaeberle: Multiline summaries have to work even if their parent details element is expanded (and they do work now as well), I won't worry about that. :)
Comment #16
fhaeberleComment #17
fhaeberle@huzooka I'm going to improve my patch.
Comment #18
fhaeberleComment #19
fhaeberleI created a new patch based on @huzooka 's suggestion in #13. Please review.
Comment #20
fhaeberleComment #21
fhaeberleComment #22
huzookaLet's do this!
Comment #24
huzooka