Views StringFilter doesn't escape % character

@kfritsche: What does query now returns without your solution?

@kfritsche: I had another look at the code of the StringFilter filter and first I thought that the operator was an "=", but now I see that the operator is "LIKE". The solution in your patch is the correct. What we now are missing is an automated test to make sure that the solution does not get undone in the future.

@kfritsche, Thank you for reporting this problem and making a patch.. We rely on issue reports like this to improve Drupal core.

I tested this on 9.3.9, standard install, and was not able to reproduce this error. I followed the steps given in the Issue Summary.

Therefore, closing as outdated.

If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

This issue still there. I tried patch 3055152-4.patch, it is correct.

Tested version: 10.3.2
Tested db: MariaDB
Problematic code: 11.x , 10.x

Reproduce step:

1. Create a view with page, choose "content" as type
2. Add filter to created views, use title as exposed filter
3. Operator choose "Is equal to"
4. Visit created views page, type testing search string into exposed filter: %abc%
5. Visit created views page, type query on the url: /test-node?title=%25abc%25
6. All the title contains abc will listed. The percentage character is not escape.

I have fixed the issue above-mentioned issue.
I attached the patch for the Drupal 10.3.5

Tested version: 10.3.5
Tested db: MariaDB

Thank you

I re-tested today with Umami on 11.x and was able to reproduce the problem. I can only assume that my earlier testing was incorrect.

@manpreet_singh, thanks for the fix. Drupal uses peer review for all changes to core, so the setting on an issue to RTBC should be done by another contributor. Thanks.

This issue will also need a test to prove the fix works and expected, adding tag.

I have able to replicate this issue and MR fixes the issue , so i will work on this for test coverage.

Hi,
I was able to replicate the issue and reviewed the existing fix in this MR. The solution appears correct, and functionality works as expected based on my testing. To validate this, I have tried to add test coverage in the FilterStringTest class, aiming to demonstrate both the issue and its resolution.

I’ve submitted a new MR against 11.x. Since there was an existing MR on 10, I’ve hidden that one to avoid any confusion. I wasn’t sure about the status of the existing MR, Apologies if you would have preferred updating the existing MR.

Please review when possible, and let me know if there’s anything further I should address.

Updated issue summary also.
Thank you!

Failing test :

1) Drupal\Tests\views\Kernel\Handler\FilterStringTest::testFilterStringEqual
Actual result <pre>
array (
  0 => 
  array (
    'name' => 'Ringo',
  ),
  1 => 
  array (
    'name' => 'Ringo%',
  ),
)
</pre> is  identical to expected <pre>
array (
  0 => 
  array (
    'name' => 'Ringo%',
  ),
)
</pre>
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 [
     0 => Array &1 [
+        'name' => 'Ringo',
+    ],
+    1 => Array &2 [
         'name' => 'Ringo%',
     ],
 ]

Moving this for Review.

Comment on MR.

I have address the feedback, also verified with another method no type cast is added, also again re ran the test and its working as expected, pipeline is also green so moving this for NR.
Kindly review.

All feedback appears to be addressed.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rebase without conflicts , so moving back to previous status.

I read the IS, comments and the MR. Everything looks in order here. I updated credit.

Committed/pushed to 11.x and cherry-picked to 10.5.x, thanks!