Recently, a hook to the D7 version of Feeds was added to be invoked before validation happens. See #3046592: Add a hook to invoke before validation. It would be useful to do something similar for the D8 version, but being an event instead.
The event can be used to fix validation issues that are preventing some items from being imported.
Add an event called "feeds.process_entity_prevalidate" and dispatch it just before validation.
None.
A new event called "feeds.process_entity_prevalidate" is added.
None.
Patch will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-3054851-4-6.txt | 2.14 KB | megachriz |
| #6 | feeds-prevalidate-3054851-6.patch | 9.88 KB | megachriz |
Comments
Comment #2
megachrizComment #3
megachrizForgot to document the method
Feed::dispatchEntityEvent()in FeedInterface.Comment #4
megachrizCoding standards fixes.
Comment #5
danielvezaThis is awesome. Nice job mate. The Paragraphs integration with feeds wasn't enough for me. I was trying to figure out what the best class to override was to do the work I needed.
Instead I was able to subscribe to the prevalidate event.
This is much cleaner. Big thumbs up.
RTBC for the functionality. Haven't done a code style review.
Comment #6
megachriz@DanielVeza
Thanks for testing! I had this feature lying around for at least a year (developed for a client) but it was tangled with a few other uncompleted - but related - features (one of the features will come in a follow-up by the way). Finally found some time to untangle it and complement it with tests.
When I intially developed this feature
Feed::eventDispatcher()did not exist yet, so that's why dispatches the entity event happened in FeedImportHandler. I think we can now skip that and dispatch the event directly in the Feed class, as the IMPORT_FINISHED event is also dispatched in that class.I commit the patch if it still passes tests.
Comment #8
megachrizComitted #6.
Comment #9
megachrizThe follow-up patch is in #2991955-6: Dispatch events before and after saving an entity during processing, where events are added for presaving and postsaving an entity.