There's a white background leak on dropbutton-widget that only can be seen on hover

Where to see this?:
The issue seems to happen on pages with a lists of rows in a table that has dropbutton-widget, but only I only found it occuring in translate lists for entities such as node or blocks, i.e: node/nid/translations

Here's a screenshot with higher contrast on hover:
A button with white background leak on hover in Seven theme

CommentFileSizeAuthor
#12 3054196-bartik.png1.81 KBindrajithkb
#12 3054196-claro.png1013 bytesindrajithkb
#9 3054196-after-patch.png2.04 KBindrajithkb
#9 3054196-before-patch.png2.03 KBindrajithkb
#6 3054196-6.patch477 bytespoojakural
#6 3054196-4.patch477 bytespoojakural
#4 Screenshot 2020-05-13 at 12.47.17 PM.png140.65 KBpoojakural
Screen Shot 2019-05-12 at 13.17.45.png8.67 KBdoxigo

Comments

doxigo created an issue. See original summary.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.9 was released on November 6 and is the final full bugfix release for the Drupal 8.7.x series. Drupal 8.7.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.8.0 on December 4, 2019. (Drupal 8.8.0-beta1 is available for testing.)

Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

poojakural’s picture

poojakural commented
Assigned: Unassigned » poojakural
poojakural’s picture

poojakural commented
Assigned: poojakural » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot 2020-05-13 at 12.47.17 PM.png140.65 KB

Removed white background when hover. Please refer the SS:

sharma.amitt16’s picture

sharma.amitt16 commented

@poojakural, I think you missed the patch. please upload the patch as SS shows the issue is fixed on your local.

poojakural’s picture

poojakural commented
StatusFileSize
new 3054196-4.patch477 bytes
new 3054196-6.patch477 bytes

@amit Please find the patch below.

poojakural’s picture

poojakural commented

Please review this patch in above attachment 3054196-6.patch

sharma.amitt16’s picture

sharma.amitt16 commented

Patch looks good to me.

+1 for RTBC.

indrajithkb’s picture

indrajithkb commented
StatusFileSize
new 3054196-before-patch.png2.03 KB
new 3054196-after-patch.png2.04 KB

Hi @pooja thanks for the #6 it's working good.

Before - patch:
before patch

After- patch :
issue after patch applied

indrajithkb’s picture

indrajithkb commented
Status: Needs review » Reviewed & tested by the community
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Can we test whether this issue affects other themes? Particularly Claro, which copied a lot of its original CSS from Seven. Thanks!

indrajithkb’s picture

indrajithkb commented
StatusFileSize
new 3054196-claro.png1013 bytes
new 3054196-bartik.png1.81 KB

Thanks @xjm pointing out this.
attaching the screenshots for claro and bartik (both are fine)

claro:
claro

bartik:
bartik

indrajithkb’s picture

indrajithkb commented
Status: Needs review » Reviewed & tested by the community

  • xjm committed 4eef94f on 9.1.x 
    Issue #3054196 by poojakural, Indrajith KB, doxigo, xjm: White...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.8.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks @Indrajith KB for confirming. :)

The thorough manual testing, good explanation, and simplicity of the change make me confident of this fix. Committed to 9.1.x as an internal theme bugfix requiring an internal CSS change. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.