Ctools made a change to its messages that broken a Password Policy test.

Ctools issue: #2985395: Add logging for EntityFormWizardBase saving the entity

Example failed test:
https://www.drupal.org/pift-ci-job/1286707

Originally identified by mmenavas: #3032549-8: Password policy module issue with saving constraint

CommentFileSizeAuthor
#8 password_policy-8.x-3.x-fix_ctools_related_test_failure-3054070-8.patch955 bytesaohrvetpv
#2 password_policy-8.x-3.x-fix_ctools_related_test_failure-3054070-2.patch953 bytesaohrvetpv

Comments

AohRveTPV created an issue. See original summary.

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new password_policy-8.x-3.x-fix_ctools_related_test_failure-3054070-2.patch953 bytes

Same change as mmenavas made, except I added a Ctools >=8.3.1 dependency. (The message change was introduced in 8.3.1.)

Status: Needs review » Needs work

The last submitted patch, 2: password_policy-8.x-3.x-fix_ctools_related_test_failure-3054070-2.patch, failed testing. View results

  • AohRveTPV committed 4596690 on 8.x-3.x authored by mmenavas 
    Issue #3054070 by mmenavas, AohRveTPV: testHistoryConstraint fails due...

AohRveTPV credited mmenavas.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Fixed

  • AohRveTPV committed 440cb3f on 8.x-3.x 
    Revert "Issue #3054070 by mmenavas, AohRveTPV: testHistoryConstraint...
  • AohRveTPV committed 4846a43 on 8.x-3.x authored by mmenavas
    Issue #3054070 by mmenavas, AohRveTPV: testHistoryConstraint fails due...
aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-8.x-3.x-fix_ctools_related_test_failure-3054070-8.patch955 bytes

The Ctools version requirement was apparently incorrectly specified. Reverted and committed this patch instead.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.