Closed (fixed)
Project:
Tome
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Reporter:
Created:
10 May 2019 at 14:36 UTC
Updated:
25 May 2019 at 22:14 UTC
Jump to comment: Most recent, Most recent file
When I implemented the content hashing feature, I thought that committing hashes to Git would be a big performance improvement, but never ran performance testing. After just testing with 100, 1000, and 10000 entities, I think the performance difference is negligible and want to change this before releasing it in the wild. We should just use sha1_file on every export instead, and should probably change the \Drupal\tome_sync\ContentHasherInterface API so that getChangedContent/getDeletedContent/getNewContent all come from one method, to avoid doing this multiple times.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3054003-2.patch | 15.39 KB | samuel.mortenson |
Comments
Comment #2
samuel.mortensonPatch!
Comment #4
samuel.mortenson