Problem/Motivation

The repository contains npm scripts to test JavaScript coding standards, but the code currently does not pass the defined standards.

Proposed resolution

Fix the reported JavaScript coding standards errors.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#10 3053987-10.patch12.32 KBquiron
#10 interdiff_3053987_8_10.txt532 bytesquiron
#8 3053987-8.patch12.41 KBidebr
#8 3053987-8-test-only.patch707 bytesidebr
#7 3053987-7-test-only.patch707 bytesidebr
#6 3053987-6-test-only.patch0 bytesidebr
#5 interdiff-3-5.txt1.09 KBidebr
#5 3053987-5.patch12.29 KBidebr
#5 3053987-5-test-only.patch679 bytesidebr
#3 3053987-3.patch15.2 KBidebr
#3 interdiff-2-3.txt300 bytesidebr
#2 3053987-2.patch14.86 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3053987-2.patch14.86 KB

Attached patch fixes the reported JavaScript coding standards errors.

idebr’s picture

idebr commented
StatusFileSize
new interdiff-2-3.txt300 bytes
new 3053987-3.patch15.2 KB

Interesting enough, the testbot still return the error Javascript coding standards error without any feedback of what errors. Let's see if this helps.

idebr’s picture

idebr commented

Filed #3054010: ESLint halt-on-fail does not provide any feedback on what failed to find out what is triggering the Javascript coding standards error message on the testbot.

idebr’s picture

idebr commented
StatusFileSize
new 3053987-5-test-only.patch679 bytes
new 3053987-5.patch12.29 KB
new interdiff-3-5.txt1.09 KB

Let's try this.

idebr’s picture

idebr commented
StatusFileSize
new 3053987-6-test-only.patch0 bytes
idebr’s picture

idebr commented
StatusFileSize
new 3053987-7-test-only.patch707 bytes
idebr’s picture

idebr commented
StatusFileSize
new 3053987-8-test-only.patch707 bytes
new 3053987-8.patch12.41 KB

This seems to do the job.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
commented
Status: Needs review » Needs work

drupalci.yml

    testing:
      container_command:
        commands:
         - "cd ${SOURCE_DIR}/themes/contrib/claro && sudo -u www-data yarn install"
         - "cd ${SOURCE_DIR}/themes/contrib/claro && sudo -u www-data yarn run lint:css"
         - "cd ${SOURCE_DIR}/themes/contrib/claro && sudo -u www-data yarn run lint:js"
         - "cd ${SOURCE_DIR}/themes/contrib/claro && sudo -u www-data yarn run lint:js"

I think the last line is too much :)

Everything else looks good. Thank you!

quiron’s picture

quiron
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review
Issue tags: +DevDaysCluj
StatusFileSize
new interdiff_3053987_8_10.txt532 bytes
new 3053987-10.patch12.32 KB

Moving it forward.

idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

@quiron Thanks!

  • lauriii committed 6152840 on 8.x-1.x 
    Issue #3053987 by idebr, quiron, fhaeberle: Fix JavaScript coding...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Looks good! Thank you everyone!

rosinegrean’s picture

rosinegrean commented
Issue tags: -DevDaysCluj +DevDaysTransylvania

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.