1. SpoolStorage::addIssue() and SpoolStorage::deleteIssue()
  2. Move duplicated code in from actions SendIssue/StopIssue and NodeTabForm
  3. Remove broken function simplenews_issue_update_sent_status() which alters the status but fails to do any other actions that might be required to legitimately change the status (and fails to verify that the new status is legitimate). Change references to this function to the new ones.

There are no bugs in the main simplenews module. There is a bug in simplenews_demo simplenews_demo.install line 198 - the mails are never spooled for the pending newsletter.

CommentFileSizeAuthor
#13 simplenews.send-cancel.3052727-13.patch23.37 KBadamps
#11 simplenews.send-cancel.3052727-interdiff-9-11.txt2.49 KBadamps
#11 simplenews.send-cancel.3052727-11.patch23.37 KBadamps
#9 simplenews.send-cancel.3052727-9.patch21.01 KBadamps
#7 simplenews.send-cancel.3052727-7.patch22.44 KBadamps
#5 simplenews.send-cancel.3052727-interdiff-3-5.txt519 bytesadamps
#5 simplenews.send-cancel.3052727-5.patch22.39 KBadamps
#3 simplenews.send-cancel.3052727-3.patch22.39 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Title: Broken function simplenews_issue_update_sent_status » Create clear consolidated functions to send/cancel newsletters
Category: Bug report » Task
Issue summary: View changes
adamps’s picture

adamps commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new simplenews.send-cancel.3052727-3.patch22.39 KB
adamps’s picture

adamps commented
Issue summary: View changes
adamps’s picture

adamps commented
StatusFileSize
new simplenews.send-cancel.3052727-5.patch22.39 KB
new simplenews.send-cancel.3052727-interdiff-3-5.txt519 bytes

Status: Needs review » Needs work

The last submitted patch, 5: simplenews.send-cancel.3052727-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.send-cancel.3052727-7.patch22.44 KB

Status: Needs review » Needs work

The last submitted patch, 7: simplenews.send-cancel.3052727-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.send-cancel.3052727-9.patch21.01 KB

Status: Needs review » Needs work

The last submitted patch, 9: simplenews.send-cancel.3052727-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.send-cancel.3052727-11.patch23.37 KB
new simplenews.send-cancel.3052727-interdiff-9-11.txt2.49 KB

Status: Needs review » Needs work

The last submitted patch, 11: simplenews.send-cancel.3052727-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.send-cancel.3052727-13.patch23.37 KB
adamps’s picture

adamps commented
Issue tags: +Plan to commit

  • AdamPS committed 919780c on 8.x-2.x 
    Issue #3052727 by AdamPS: Create clear consolidated functions to send/...
adamps’s picture

adamps commented
Status: Needs review » Fixed
Issue tags: -Plan to commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.