5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------
Line src/Controller/AnimateListController.php
------ ------------------------------------------------
45 Call to deprecated function drupal_render().
70 Call to deprecated method l() of class Drupal.
------ ------------------------------------------------

------ ---------------------------------------------------
Line src/Form/AnimateAnyForm.php
------ ---------------------------------------------------
28 Call to deprecated function drupal_set_message().
170 Call to deprecated function drupal_set_message().
------ ---------------------------------------------------

------ ---------------------------------------------------
Line src/Form/AnimateDeleteForm.php
------ ---------------------------------------------------
52 Call to deprecated function drupal_set_message().
------ ---------------------------------------------------

------ ---------------------------------------------------
Line src/Form/AnimateEditForm.php
------ ---------------------------------------------------
132 Call to deprecated function drupal_set_message().
------ ---------------------------------------------------

CommentFileSizeAuthor
#7 3051183-7.patch13.55 KBrasikap
#5 3051183-5.patch9.36 KBrasikap
#2 3051183-2.patch3.64 KByogen.prasad

Comments

yogen.prasad created an issue. See original summary.

yogen.prasad’s picture

yogen.prasad commented
Status: Active » Needs review
StatusFileSize
new 3051183-2.patch3.64 KB
virajrajankar’s picture

virajrajankar commented
rasikap’s picture

rasikap commented
Assigned: Unassigned » rasikap
rasikap’s picture

rasikap commented
StatusFileSize
new 3051183-5.patch9.36 KB

Added patch to refactor code to match the recent coding standards using dependency injection. Please review.

Thanks,
Rasika!

kaustubhb’s picture

kaustubhb commented

I reviewed the patch above just a quick suggestion. Please use dependancy injection instead of direct use of database.

rasikap’s picture

rasikap commented
StatusFileSize
new 3051183-7.patch13.55 KB

Updated the patch to use dependency injection for database service.

Thanks!

virajrajankar’s picture

virajrajankar commented
virajrajankar’s picture

virajrajankar commented
Status: Needs review » Fixed
virajrajankar’s picture

virajrajankar commented
Status: Fixed » Closed (fixed)