I just got a patch posted on a very old, very dead module: https://www.drupal.org/project/twig_debug/issues/3050882
I was curious, since I didn't think anyone was using it (it only worked with ancient versions of Drupal 8).
So I inspected the posters profile: https://www.drupal.org/u/alonaoneill
The user has apparently posted thousands of patches, all with the same message:
I uploaded a patch that [fixes minor cosmetic issue] in the .info.yml file.
Thanks!
I would guess that this is the work of a bot. It's probably worth considering whether such activity should be allowed on d.o. It is accumulating a lot of commit credits, perhaps to put Hook42 higher on the list of contributors, without actually contributing anything of value.
At the very least, if someone is posting automated patches, they should be honest about it, clearly stating that this is machine-generated code.
Comments
Comment #2
avpadernoIt doesn't seem the user is posting automated patches. Even if PHP_CodeSniffer were used, the user would still need to clone the project locally and run the command to see what changes are suggested.
While the user seems to focus on the content of .info.yml files, the reports are tailored for really existing issues. Even if it could seem a minimal contribution, it still contributing.
Comment #3
miklGiven how much time is wasted reviewing and merging such "contributions", I highly doubt that it is a net positive. Especially if they're posting them on old obsolete projects.
But hey, Drupal is kinda dead to me anyway, if you want to allow such behavior here, I'll just go turn off notifications for new issues.
Comment #4
avpadernoWhen the patch was provided, the project was not showing as unsupported and obsolete.
As side note, if you don't want to get notification from that project issues, or be associated to it (for example, when somebody wants to take over it, or re-use the project namespace for a new project), the project can be moved to the Unsupported Projects user.
Comment #5
miklMakes no difference, the project was clearly dead. No releases. No usage. Only five commits. No code changes in four years.
But even if it was an active project, posting patches like these is a huge waste of everyone's time. In some cases, their capitalization algoritm is even wrong, removing underscores from names that needs underscores in them, or capitalizing words that are not capitalized under title case rules, like "for".
Comment #6
gisleI agree with kiamlaluno (in particular comment #4). This is not spam, but an attempt made in good faith to fix a coding standard issue. Also, it does not look automated to me.
We actually encourage people to contribute here, so we should very careful when using the word "spam" when somebody tries to contribute.
I think this issue should be closed, as there has been no activity for three months (before I chipped in), but I leave it to kiamlaluno or mikl to make the call.
Comment #7
mikl@gisle it might have been well intentioned, but it's still a huge waste of time posting hundreds of such patches. It improves nothing, it just waste maintainer time having to deal with the issues. It is functionally spam.
Comment #8
gislemikl wrote:
The community happens to have some guidelines about the stuff that goes into the the repo, and one those guidelines are:
(See for intstance: https://www.drupal.org/docs/develop/documenting-your-project/help-text-s....)
You may even disagree with this particular guideline, and choose to ignore in the projects you maintain – and that's also OK. However, to use the word "spamming" to characterize the contribution of another community member who wants to help out with getting those guidelines followed is IMHO not treating others with the respect they deserve.
You have a lot of options here, but most appropriate is already mentioned in comment #4: Hand any project you no longer maintain over to the 'Unsupported Projects' user. That saves others from wasting time trying to contribute to the project, and you from wasting time reviewing patches.
(And you've probably wasted more time complaining about this than you did eyeballing the proposed patch in the first place.)
Comment #9
avpadernoI would also not say it's a waste of time for the project maintainer, as the user has opened just two issues per project.
What can be done is correcting the user when she is posting a wrong patch, or she misunderstood what the guidelines say.
Comment #10
avpadernoI am closing this issue, since two webmasters answered. I am also changing the title to better describe what the support request was asking.
Comment #11
miklMighy arrogant of you to rewrite my words for me.
Of course posting similar patches is allowed. Question was if posting large amounts of largely useless patches is allowed.
Allowing patches like these, enables unscrupulous companies to inflate their commit credit numbers on d.o, to look like they’re big open source contributors. I think allowing this is harmful to the ecosystem.
Comment #12
avpadernoWhat described here is not spamming; therefore, I changed the title to better describe what the issue discussed here is, given that the title is thought to give an idea of what the issue is, not describing it exactly. You are free to change it, as long as spamming (or a similar word) doesn't compare in the title.
No, they aren't useless patches, by drupal.org standards. If you consider them useless, you are free to ignore them, but that is not a webmasters issue.
Comment #13
miklThat’s semantics. You might not think it was spamming. I certainly do. You can disagree with my choice of words if you want, but don’t edit my posts just because you disagree with my wording.
Yeah, I think you’ve established that. Every contribution counts, even changing word capitalization. I think that undermines the value of commit credits. I guess we can just call this “won’t fix”.
Comment #14
avpadernoIt's a support request. There isn't anything that needs to be fixed, as you just asked a question, which has been answered.
No, that is not spamming by Drupal.org terminology, and by Drupal.org webmasters terminology. Since this issue is in the webmasters queue, the title must make clear what the webmasters need to do.
Comment #15
miklSee, that’s where we disagree.
I don’t care what your terminology is.
Comment #16
avpadernoSince this is the webmasters issue queue, your terminology is irrelevant.
Comment #17
avpaderno