Drupal 9 Deprecated Code Report [#3050858]

Problem/Motivation


 ------ ------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Checks/Extensions/Count.php  
 ------ ------------------------------------------------------------------------------------------------- 
         Class Drupal\site_audit\Check not found and could not be autoloaded.                             
 ------ ------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Commands/SiteAuditCommands.php  
 ------ ---------------------------------------------------------------------------------------------------- 
  63     Call to deprecated method getOutput() of class Drush\Commands\DrushCommands.                        
 ------ ---------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/ContentDuplicateTitles.php  
 ------ ---------------------------------------------------------------------------------------------------------------------- 
  90     Call to deprecated function db_select().                                                                              
  102    Call to deprecated method entityManager() of class Drupal.                                                            
 ------ ---------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------ 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/ContentEntityTypes.php  
 ------ ------------------------------------------------------------------------------------------------------------------ 
  89     Call to deprecated method entityManager() of class Drupal.                                                        
 ------ ------------------------------------------------------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/ContentFieldCount.php  
 ------ ----------------------------------------------------------------------------------------------------------------- 
  87     Call to deprecated method entityManager() of class Drupal.                                                       
 ------ ----------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/ContentFieldInstances.php  
 ------ --------------------------------------------------------------------------------------------------------------------- 
  86     Call to deprecated method entityManager() of class Drupal.                                                           
 ------ --------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/ContentVocabularies.php  
 ------ ------------------------------------------------------------------------------------------------------------------- 
  93     Call to deprecated method entityManager() of class Drupal.                                                         
  95     Call to deprecated function db_select().                                                                           
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/DatabaseCollation.php  
 ------ ----------------------------------------------------------------------------------------------------------------- 
  93     Call to deprecated function db_select().                                                                         
 ------ ----------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/DatabaseEngine.php  
 ------ -------------------------------------------------------------------------------------------------------------- 
  91     Call to deprecated function db_select().                                                                      
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/DatabaseFragmentation.php  
 ------ --------------------------------------------------------------------------------------------------------------------- 
  75     Call to deprecated function db_select().                                                                             
 ------ --------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/DatabaseRowCount.php  
 ------ ---------------------------------------------------------------------------------------------------------------- 
  79     Call to deprecated function db_select().                                                                        
 ------ ---------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------ 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/DatabaseSize.php  
 ------ ------------------------------------------------------------------------------------------------------------ 
  61     Call to deprecated function db_select().                                                                    
 ------ ------------------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/UsersBlockedNumberOne.php  
 ------ --------------------------------------------------------------------------------------------------------------------- 
  60     Call to deprecated function db_select().                                                                             
 ------ --------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/UsersCountAll.php  
 ------ ------------------------------------------------------------------------------------------------------------- 
  57     Call to deprecated function db_select().                                                                     
 ------ ------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/UsersCountBlocked.php  
 ------ ----------------------------------------------------------------------------------------------------------------- 
  61     Call to deprecated function db_select().                                                                         
 ------ ----------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/UsersRolesList.php  
 ------ -------------------------------------------------------------------------------------------------------------- 
  58     Call to deprecated function db_select().                                                                      
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/ViewsCount.php  
 ------ ---------------------------------------------------------------------------------------------------------- 
  69     Call to deprecated method entityManager() of class Drupal.                                                
 ------ ---------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/Watchdog404.php  
 ------ ----------------------------------------------------------------------------------------------------------- 
  71     Call to deprecated function db_select().                                                                   
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/WatchdogAge.php  
 ------ ----------------------------------------------------------------------------------------------------------- 
  69     Call to deprecated function db_select().                                                                   
  76     Call to deprecated function db_select().                                                                   
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/WatchdogCount.php  
 ------ ------------------------------------------------------------------------------------------------------------- 
  66     Call to deprecated function db_select().                                                                     
 ------ ------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   /var/www/html/drupal/web/modules/contrib/site_audit/src/Plugin/SiteAuditCheck/WatchdogPhp.php  
 ------ ----------------------------------------------------------------------------------------------------------- 
  74     Call to deprecated function db_select().                                                                   
 ------ ----------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 24 errors

Comment	File	Size	Author
#7	d9_depreciation-3050858-7.patch	18.07 KB	waverate
#5	d9_depreciation-3050858-5.patch	12.38 KB	waverate
#4	d9_depreciation-3050858-4.patch	16.47 KB	waverate

Comments

Comment #1

25 April 2019 at 22:05

waverate created an issue. See original summary.

Comment #2

waverate commented 25 April 2019 at 22:06

Issue summary:

View changes

Comment #3

waverate commented 25 April 2019 at 22:11

Issue tags:

+Drupal 9 compatibility

Comment #4

waverate commented 27 April 2019 at 19:32

Status:

Active

» Needs review

Status	File	Size
new	d9_depreciation-3050858-4.patch	16.47 KB

Patch attached.

Comment #5

waverate commented 27 April 2019 at 19:44

Status	File	Size
new	d9_depreciation-3050858-5.patch	12.38 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	d9_depreciation-3050858-4.patch	16.47 KB

Patch at #4 doesn't work. Here's one that takes care of only db_select().

Comment #6

waverate commented 27 April 2019 at 20:26

drupal-check after patch at #5.

 ------ ---------------------------------------------------------------------- 
  Line   src/Checks/Extensions/Count.php                                       
 ------ ---------------------------------------------------------------------- 
         Class Drupal\site_audit\Check not found and could not be autoloaded.  
 ------ ---------------------------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   src/Commands/SiteAuditCommands.php              
 ------ ------------------------------------------------ 
  63     Call to deprecated method getOutput() of class  
         Drush\Commands\DrushCommands.                   
 ------ ------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/SiteAuditCheck/ContentDuplicateTitles.php        
 ------ ------------------------------------------------------------ 
  102    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/SiteAuditCheck/ContentEntityTypes.php            
 ------ ------------------------------------------------------------ 
  89     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/SiteAuditCheck/ContentFieldCount.php             
 ------ ------------------------------------------------------------ 
  87     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/SiteAuditCheck/ContentFieldInstances.php         
 ------ ------------------------------------------------------------ 
  86     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/SiteAuditCheck/ContentVocabularies.php           
 ------ ------------------------------------------------------------ 
  93     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/SiteAuditCheck/ViewsCount.php                    
 ------ ------------------------------------------------------------ 
  69     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

                                                                                
 [ERROR] Found 8 errors

Comment #7

waverate commented 27 April 2019 at 21:49

Status	File	Size
new	d9_depreciation-3050858-7.patch	18.07 KB

Updated patch at #5 to take care of db_select() and entityManager() depreciations.

Comment #8

waverate commented 27 April 2019 at 21:50

drupal-check after patch at #7:

 ------ ---------------------------------------------------------------------- 
  Line   src/Checks/Extensions/Count.php                                       
 ------ ---------------------------------------------------------------------- 
         Class Drupal\site_audit\Check not found and could not be autoloaded.  
 ------ ---------------------------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   src/Commands/SiteAuditCommands.php              
 ------ ------------------------------------------------ 
  63     Call to deprecated method getOutput() of class  
         Drush\Commands\DrushCommands.                   
 ------ ------------------------------------------------ 

                                                                                
 [ERROR] Found 2 errors

Comment #9

10 May 2019 at 13:53

jrglasgow committed ffcf2dd on 8.x-3.x authored by waverate

Issue #3050858 by waverate: Drupal 9 Deprecated Code Report

Comment #10

jrglasgow commented 10 May 2019 at 13:54

Status:

Needs review

» Fixed

Comment #11

24 May 2019 at 13:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

News items

Our community

Documentation

Drupal code base

Governance of community