If we're going to enforce that data types in param, return, and var tags are fully namespaced, it seems like @throws tags should join the lot.

CommentFileSizeAuthor
#4 coder-3050837-4.patch2.79 KBdanepowell
#2 coder-3050837-2.patch1.18 KBdanepowell

Comments

Dane Powell created an issue. See original summary.

danepowell’s picture

danepowell commented
Status: Active » Needs review
StatusFileSize
new coder-3050837-2.patch1.18 KB
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Makes sense!

Can you add a test case and create a pull request against https://github.com/pfrenssen/coder so that we see the automated tests run?

danepowell’s picture

danepowell commented
Status: Needs work » Needs review
StatusFileSize
new coder-3050837-4.patch2.79 KB

No problem, thanks for the quick response: https://github.com/pfrenssen/coder/pull/36

  • klausi committed 7cd8491 on 8.x-3.x 
    feat(DataTypeNamespace): Data types in @throws tags must be fully...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Fixed
Issue tags: -Needs tests

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.