Based on https://www.drupal.org/project/commerce/issues/2890727.

We have custom PaymentInformation and PaypmentProcess Panes in place.
The default panes are in disabled area. Therefore it is not possible to save the checkoutflow anymore.

Proposed solution: check for _disabled step_id in pane configuration in order to avoid that.

CommentFileSizeAuthor
#7 commerce_payment-3050770-7.patch1.12 KBjsacksick
#6 commerce_payment-3050770-6.patch1.12 KBjsacksick
#5 commerce_payment-3050770-5.patch964 bytesjsacksick
#2 3050770-1.patch949 bytescarstenG
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

carstenG created an issue. See original summary.

carstenG’s picture

carstenG CreditAttribution: carstenG at FFW commented
FileSize
3050770-1.patch949 bytes

Attaching the patch.

carstenG’s picture

carstenG CreditAttribution: carstenG at FFW commented
Status: Active » Needs review
jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro for PayPal, Inc commented

The patch should also cover the case where either one of the 2 panes isn't even present.

The attached patch should also cover that and skip validation if:

  • Either the PaymentInformation or the PaymentProcess pane isn't present.
  • One of the 2 panes (PaymentProcess is tested) is on the disabled step.
jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro for PayPal, Inc commented
FileSize
commerce_payment-3050770-5.patch964 bytes

Forgot to attach the patch...

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro for PayPal, Inc commented
FileSize
commerce_payment-3050770-6.patch1.12 KB

Alternative version.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro for PayPal, Inc commented
FileSize
commerce_payment-3050770-7.patch1.12 KB

Sorry the patch in #6 isn't correct, here's a new one.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Cannot save Checkout flow » Payment checkout flow validation fails when payment panes are disabled or missing

Better title.

astringer’s picture

astringer CreditAttribution: astringer as a volunteer commented

Confirming, the patch from #7 worked for me.

  • bojanz committed 2ff34df on 8.x-2.x authored by carstenG 
    Issue #3050770 by jsacksick, carstenG: Payment checkout flow validation...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed
Issue tags: -Novice

Committed, thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.