there could be an option to read images from a file directory
required changes:
configurable directory settings like /pictures/$nid and /pictures/$nid/thumb (or thumb_prefix for thumbnail images)
jcarousel_block_imagefield_type = "directory"
function _jcarousel_block_preprocess_directoryimage()
Comments
Comment #1
pasqualleComment #2
pasquallenote1:
the cck dependency and the line 124
in jcarousel_block.module must be removed to work with directoryimage
note2:
there could be a simple plugin system like
imceimage.inc
imagefield.inc
directoryimage.inc
and all should have an equally named jcarousel_block_preprocess_image(&$variables) function, and any other function necessary.
this way it would be possible to add new types without altering the main module files..
Comment #3
yang_yi_cn commentedthanks for your contribution! I'll test it and add to the release.
Comment #4
yang_yi_cn commentedI've added the directoryimage support. Released as 1.4.
A few questions:
1. Is the '/pictures/$nid' pattern used by any other module? How should we expect the user to upload images under this pattern?
2. About the plug-in system, I'm thinking about it. However I would need not just the jcarousel_block_preprocess_image() function, but also some other functions such as empty check, and admin settings, which might take sometime. Please create another bug for that feature, so I can close this bug here.
Comment #5
pasqualle1.
a) I am not sure. It was just my first idea how to name the directory. it should be something like the pathauto settings..
b) imce, ftp or custom module.
2. agreed #313835: create a simple plugin functionality to easily swap the image system
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.