Found a number of problems while reviewing #2905028: Add a per-gateway setting to skip collecting billing information:
1) PaymentMethodAddForm and PaymentMethodEditForm use Profile:: even though the entity type manager is injected.
2) PaymentMethodAddForm has route-or-default-store logic which duplicates the resolved store logic. We should inject the currentStore service and get the store from there instead.
3) PaymentMethodEditForm doesn't validate the newly entered CC expiration date.
Plus, we could use a PaymentMethodFormBase, which injects the common dependencies and handles the billing information.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3050301-2-payment-method-plugin-forms.patch | 17.89 KB | bojanz |
|
Comments
Comment #2
bojanz CreditAttribution: bojanz at Centarro commentedLet's try this.
Comment #3
bojanz CreditAttribution: bojanz at Centarro commentedCommitted.