Problem/Motivation

Found in #3048698: Content moderation layout builder integration fails when a node has an associated menu item
@alexpott

$entity->menu is added by menu_ui_node_builder() which is added by a form alter - menu_ui_form_node_form_alter(). But the constraint is added on menu_ui_entity_type_build() level - so it is always present. Which makes the menu_ui not the most API friendly module. Is there an existing issue which covers this problem?

It seems weird to use Entity constraint for something that is only added via a form. I think if you were doing the same action say over JSON API you would make to POST/PATCH requests because this is actually 2 different content entities. In that case a entity level constraint makes no sense. So that would mean moving from using an entity constraint to I guess form validation function.

Proposed resolution

Determine if this validation should actually be a form validator

Remaining tasks

Determine best solution(or not change) and do it.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3050199

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented

Triaging my issue queue.

This still appears to be valid, since moved to hooks but still doing the same. Guess the thing to see is if it is on the form can it pick up the if it's a pending revision.

smustgrave opened merge request !16155

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

used claude slightly to help with the validator but relatively easy to convert :)

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

I've read the MR, looks good to me.

  • catch committed f243112a on 11.x 
    task: #3050199 Remove entity level constraint MenuSettingsConstraint...

  • catch committed 214876bb on main 
    task: #3050199 Remove entity level constraint MenuSettingsConstraint...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

@smustgrave do we publish the CR now?

Oh that's probably done on release, don't mind me

catch’s picture

catch
he/him
Primary language English
commented

No @darvenen that's a good question - we publish when things get committed. In this case I was debating with myself whether we needed a change record since individual validators are considered internal, but then forgot entirely. Since it's already written and looks fine, went ahead and published.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Thanks for the update @catch, appreciate it :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.