Replace deprecated function assertText() with pageTextContains()

I hope, this patch will solve the issue.

Hi AkashkumarOSL,
Thanks for re-rolling the patch. Looking at the tests which failed:

• SchedulerPermissionsTest and SchedulerPastDatesTest both use Html::escape around the text to check for. This may be causing the problem, as it might not be required in the new assert method. At least, that is a good place to start investigating.
• In SchedulerLightweightCronTest you have a typo, with a double $$
  

  +    $$this->assertSession()
  

Jonathan

Fixed the issues suggested in #6

Hi shubham.prakash,
Thanks for the new patch. SchedulerLightweightCronTest now passes because you have removed the double $$. Also SchedulerPermissionsTest and SchedulerPastDatesTest now pass because you have removed the unnecessary Html::escape . So those are both good. There are now two unused use statements which should be removed (see the coding standards output on the test results page)

However, in re-rolling the patch you have introduced new test failures in SchedulerRulesActionsTest because you have removed ->pageTextContains() in four places.

When making an updated patch, have you considered creating an interdiff file? This will show you the changes between two patches and will give you confidence that you have only changed what you intended to change. It is also very helpful for others who are reviewing the patch. The alternative is to do a file-compare on the two patches, which I have just done, to see how they differ.

Made changes as suggested in #8, also I'll try to upload interdiff whenever possible. Thanks.

Thank you, you fixed the coding standard, and the tests pass.

I noticed one assertText that got missed, see interdiff, but I can fix this on commit.

The new pageTextContains() only accepts one parameter, the text to search for. Any other parameters are ignored, but it make sense to remove the extra values anyway.

Thank you all. Committed and fixed.