Closed (outdated)
Project:
User Revision
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Apr 2019 at 15:35 UTC
Updated:
7 Feb 2021 at 00:57 UTC
Jump to comment: Most recent
The code in the install file currently is not robust and can lead to data loss when the module is enabled from the UI.
Workaround: Use drush to enable the module.
We now have a core API that we can leverage:
New Entity Update API for converting the schema of a content entity type, with or without pre-existing data | Drupal.org#1869582
See https://api.drupal.org/api/drupal/core%21modules%21taxonomy%21taxonomy.p...
Comments
Comment #2
znak commentedComment #3
znak commentedComment #4
geek-merlinSetting to critical as of #3057189: Does not install on Drupal 8.7 anymore.
Comment #5
geek-merlinAlso installing via web can result in data loss so bonus points for adding a batch. Example see here.
Comment #6
thomasmurphy commentedIf anyone can come up with a hours estimate to get this module working again (via this issue, at least according to the discussion at https://www.drupal.org/project/user_revision/issues/3057189) then I can look into funding the work. Also, does it seem to other people like this module is actually abandoned based on the level of developer activity on the issue queue?
Comment #7
geek-merlinJust seen by chance that some code that leverages batch api for the update is in #2794019: Installation issues and support for role IDs.
Comment #8
geek-merlin#6: As co-maintainer, i can say i have no bandwidth, paid or not. You might want to PM @attiks.
I have no permission to flag this module as "seeking co-maintainers", but i'd support an issue to do this.
Comment #9
thomasmurphy commented#8: thanks for the context. We've decided to pursue a different "audit log" approach, because our use case is needing visibility over who changed what when, rather than need to revert specifically. Also I've heard that core has decided to not go down the route of revisionable users because of security vulnerabilities, so this module's approach seems to be moving towards unsupportable, which is a pity because I've found it very useful on D7.
Comment #10
geek-merlinI wouldn't say that user revisions are dead (or do you have a reference for that claim?) but do not see much traction here either. Crosslinking core issue.
Comment #11
jayelless commentedRefer to the discussion on #2745619: [policy, no patch] Which core entities get revisions? for statements by core maintainers that user entity revisions will not be included in core. Refer also to the following issues for additional background:
In light of this, I have updated the user_history module to provide the functionality for a change audit or log of updates to user entities that is necessary to allow Drupal system to satisfy criteria for use in enterprise systems. This module had a D6 version, but was never updated for a D7 release.
Comment #12
jayelless commentedComment #13
geek-merlinYes, as i read that discussion, user does not have revisions for now, and the followup issue was "closed/outdated" with no discusstion. So if someone works that issue, it may imho land.
That said, thanks for rolling and linking the other module! 👍
Comment #14
geek-merlinWow, we can do even better by leveraging a core service: Content entity types with existing data can now be converted to be revisionable
Comment #15
geek-merlinClarifying title. I guess the risk enabling the module via drush is low, but any install via UI can lead to data loss on timeout for not-very-small user counts.
Comment #16
geek-merlinClarified to use drush in the IS.
Comment #17
geek-merlinComment #18
geek-merlinHere's the party now.