Mini pager

The buttons are now implemented as a square. This is how I would interpret the design system as well. It would be good to confirm this with the design team since this is inconsistent with the full pager.

Another question; should we keep the current page as a link? It doesn't seem useful since it would always link to the current page.

1. +++ b/claro.theme
   @@ -763,3 +763,40 @@ function claro_preprocess_views_ui_display_tab_bucket(&$variables) {
   +  if($variables['items']['current'] > 1) {
   ...
   +  if($variables['quantity'] - $variables['items']['current'] > 0) {
   

   Nit: Space between if and opening parenthesis

2. +++ b/claro.theme
   @@ -763,3 +763,40 @@ function claro_preprocess_views_ui_display_tab_bucket(&$variables) {
   +      $query['page'] = $variables['current'];
   

   I'm getting following error if I access /admin/content/media:

   Notice: Undefined index: current in claro_preprocess_views_mini_pager() (line 852 of themes/claro/claro.theme).
   claro_preprocess_views_mini_pager(Array, 'views_mini_pager', Array) (Line: 287)
   Drupal\Core\Theme\ThemeManager->render('views_mini_pager', Array) (Line: 430)

1. +++ b/claro.theme
   @@ -843,3 +843,40 @@ function claro_preprocess_views_ui_display_tab_bucket(&$variables) {
   +  // If there are additional pages, create an item that advances to the last
   +  // page. In some instances, it will also be necessary to create an item that
   +  // advances to the next page.
   +  if ($variables['quantity'] - $variables['items']['current'] > 0) {
   +    $query['page'] = $variables['quantity'] - 1;
   +    $current_url->setOption('query', $query);
   +    $variables['items']['last']['href'] = $current_url->toString();
   

   It doesn't seem like this is working. I get a link to the last page even on the last page.

2. +++ b/claro.theme
   @@ -843,3 +843,40 @@ function claro_preprocess_views_ui_display_tab_bucket(&$variables) {
   +    // The Content view (and perhaps others?) do not provide a "next" item to
   +    // the mini pager, even when there is definitely a next page. In those
   +    // instances, one can be generated here.
   +    if (!isset($variables['items']['next'])) {
   +      $query['page'] = $variables['current'];
   +      $current_url->setOption('query', $query);
   +      $variables['items']['next']['href'] = $current_url->toString();
   +    }
   

   What are the steps to reproduce the problem this is trying to solve? I still get the notification that I mentioned in #10.2 on lists that only contain one page and I'm wondering if we could remove this.

3. +++ b/css/src/components/pager.css
   @@ -118,6 +118,31 @@
   +.pager--mini span.pager__link.is-active:hover {
   

   We shouldn't assume the element type. Let's remove span from the selector.

1. +++ b/claro.theme
   @@ -843,3 +843,39 @@ function claro_preprocess_views_ui_display_tab_bucket(&$variables) {
   +    /*if (!isset($variables['items']['next'])) {
   +      $query['page'] = $variables['items']['current'];
   +      $current_url->setOption('query', $query);
   +      $variables['items']['next']['href'] = $current_url->toString();
   +    }*/
   

   Instead of commenting these lines, we should remove these. Other than that, I think we're close to getting this finished 🥳

2. I still see the last item page link on the last page. For some reason, the last page link is linking to page 8, even though I only have only 4 pages. 🤷‍♂️

@AntoineH is right, it's not possible to implement the last page link. We also shouldn't add those since it's one of the reasons mini pager exists - it's supposed to bring better performance to views with lots of pages.

We could generate the first-page link since it's always the same, but it feels like we shouldn't have the first-page link without the last-page link. Here's a version that has both of them removed.

Tested both, mini pager and full pager manually to ensure that there are no regressions. Everything looked as expected.

Made a minor documentation improvement. Interdiff attached.

Thanks everyone!