Replace deprecated node_type_get_types() with NodeType::loadMultiple()
https://api.drupal.org/api/drupal/core%21modules%21node%21node.module/fu...

Line 476: scheduler.module, has the above deprecated method.
Occurrences: 1
Files affected: 1

The API says that node_type_get_types() is deprecated in 8.x but there is no @trigger_error() yet, so this is not showing in any deprecation report.

CommentFileSizeAuthor
#2 deprecated-node_type_get_types-3049266-1.patch701 bytesbajah1701

Comments

bajah1701 created an issue. See original summary.

bajah1701’s picture

bajah1701 commented
StatusFileSize
new deprecated-node_type_get_types-3049266-1.patch701 bytes
bajah1701’s picture

bajah1701 commented
Status: Active » Needs review
amit.drupal’s picture

amit.drupal commented
Status: Needs review » Reviewed & tested by the community

Review Patch #2, Its Looking good.
Its Ready for RTBC.

jonathan1055’s picture

jonathan1055 commented

Thanks bajah1701 and amit.drupal for your work on this.
Before I commit, can you post a link to the Change Record on drupal.org. I would like to see the details behind the change, and work out why it is not covered by @deprecated or @trigger_error()

bajah1701’s picture

bajah1701 commented

@jonathan1055, I couldn't find an explicit tag that says change record that I could direct you to, however the node api clearly says that it will be deprecated in version 9 also gives the method that should replace it.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Thanks for the link.

jonathan1055’s picture

jonathan1055 commented

Your patch looks good, but I am not going to commit anything until #3049433: Coding standards not running on d.o. - upgrade to coder 8.3.4 is fixed, because phpcs is not currently being run on contrib modules, so coding standards are not being checked.

jonathan1055’s picture

jonathan1055 commented
Assigned: bajah1701 » Unassigned
Status: Reviewed & tested by the community » Fixed

My Travis testing showed that coding standards were all OK, so committed and fixed.
Thanks bajah1701.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.