Needs review
Project:
Facets
Version:
2.0.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2019 at 11:37 UTC
Updated:
9 Oct 2024 at 10:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
adhariwal commentedComment #3
nileshlohar commentedComment #5
amit.drupal commentedRerole patch #2
Comment #7
serhii shandaliuk commentedSolved the warning in the widget file and fix the problem with the composer patch applying. Also, disable the default option only by reset option config value.
Comment #8
realgt commentedreworked the patch in #7 for Drupal 9.4.5
Comment #9
suresh prabhu parkala commentedThe patch did not apply. Re-rolled to the latest 2.0.x. Please review.
Comment #10
mkalkbrennerThis is not correct. Instead of the hardcoded filter key "f" the one configured in the backend has to be used.
Comment #11
tjmoyer commentedThe last patch does not apply to 2.0.6. Here's a re-rolled patch. Please review.
Comment #12
anand.toshniwal93 commented.
Comment #13
anand.toshniwal93 commentedComment #14
anand.toshniwal93 commentedComment #15
anand.toshniwal93 commentedin previous comment added blank patch by mistake
Comment #16
anand.toshniwal93 commented.
Comment #17
anand.toshniwal93 commentedThis is the correct patch, The latest patch here https://www.drupal.org/project/facets/issues/2811331 (comment 60) adds disabled attribute to reset option.
Added a check if disabled attribute is present then remove it. so that reset option can be used.
Sorry for the multiple previous comments 🙏
Comment #18
anand.toshniwal93 commented?f%5B0%5D=cloned&f%5B1%5D=services%3Aservice%201&keywords=clonedComment #19
anand.toshniwal93 commentedThis patch will get applied if you are using patch from Create a multiple select dropdown widget
Had to create a separate patch for this as both patches making change on same line.
Comment #20
anand.toshniwal93 commentedRemoved extra added condition to verify if test pass.
Comment #21
tjmoyer commentedUpdated the patch to work with Facets 2.0.8.
Comment #22
xavier.massonI've removed the "disabled" property on the default option when using it to reset facet.