Comments

adhariwal created an issue. See original summary.

adhariwal’s picture

StatusFileSize
new3.64 KB
nileshlohar’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: add-reset-option-3049100.patch, failed testing. View results

amit.drupal’s picture

Status: Needs work » Needs review
StatusFileSize
new3.69 KB

Rerole patch #2

Status: Needs review » Needs work

The last submitted patch, 5: add-reset-option-3049100-5.patch, failed testing. View results

serhii shandaliuk’s picture

StatusFileSize
new4.9 KB

Solved the warning in the widget file and fix the problem with the composer patch applying. Also, disable the default option only by reset option config value.

realgt’s picture

StatusFileSize
new3.6 KB

reworked the patch in #7 for Drupal 9.4.5

suresh prabhu parkala’s picture

Status: Needs work » Needs review
StatusFileSize
new3.6 KB

The patch did not apply. Re-rolled to the latest 2.0.x. Please review.

mkalkbrenner’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Needs work
+++ b/js/dropdown-widget.js
@@ -101,4 +107,35 @@
+      param[index] = 'f[' + index + ']=' + value;

This is not correct. Instead of the hardcoded filter key "f" the one configured in the backend has to be used.

tjmoyer’s picture

StatusFileSize
new3.61 KB

The last patch does not apply to 2.0.6. Here's a re-rolled patch. Please review.

anand.toshniwal93’s picture

StatusFileSize
new0 bytes

.

anand.toshniwal93’s picture

anand.toshniwal93’s picture

anand.toshniwal93’s picture

StatusFileSize
new2.43 KB

in previous comment added blank patch by mistake

anand.toshniwal93’s picture

StatusFileSize
new4.08 KB

.

anand.toshniwal93’s picture

StatusFileSize
new3.94 KB

This is the correct patch, The latest patch here https://www.drupal.org/project/facets/issues/2811331 (comment 60) adds disabled attribute to reset option.
Added a check if disabled attribute is present then remove it. so that reset option can be used.

Sorry for the multiple previous comments 🙏

anand.toshniwal93’s picture

Status: Needs work » Needs review
StatusFileSize
new4.47 KB
  1. Fixed point mentioned by @mkalkbrenner.
  2. Updated condition in `cleanCurrentFilter` so that querystring which are not related to facets should be ignored while processing. I had exposed filter on form and it was being added to URL as ?f%5B0%5D=cloned&f%5B1%5D=services%3Aservice%201&keywords=cloned
anand.toshniwal93’s picture

StatusFileSize
new3.99 KB

This patch will get applied if you are using patch from Create a multiple select dropdown widget

Had to create a separate patch for this as both patches making change on same line.

anand.toshniwal93’s picture

StatusFileSize
new4.07 KB

Removed extra added condition to verify if test pass.

tjmoyer’s picture

StatusFileSize
new3.61 KB

Updated the patch to work with Facets 2.0.8.

xavier.masson’s picture

StatusFileSize
new3.67 KB

I've removed the "disabled" property on the default option when using it to reset facet.