LTR Supported view
Create Basic page English LTR

RTL Supported view
Create Basic page RTL

CommentFileSizeAuthor
#8 3048286-8.patch574 bytesrajab natshah
#3 3048286-3.patch570 bytesrajab natshah

Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Add support for RTL » Add cursor position direction support for RTL
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new 3048286-3.patch570 bytes
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » Unassigned
Status: Active » Needs review
m.abdulqader’s picture

m.abdulqader commented

Thank you Rajab :)

mohammed j. razem’s picture

mohammed j. razem
Location Santa Clara, CA
commented
Status: Needs review » Reviewed & tested by the community

This is a very simple patch - we've been using it on hundreds of website in Varbase distro.

Marking as RTBC.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Thank you for the patch.

I created a PR from the on GH: https://github.com/BurdaMagazinOrg/module-length-indicator/pull/14

Tests are currently failing for that PR: https://travis-ci.org/BurdaMagazinOrg/module-length-indicator/builds/613...

A new PR from you against https://github.com/BurdaMagazinOrg/module-length-indicator/pull/14 would be ideal. Or you can provide an interdiff. I will then apply that to the PR.

rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new 3048286-8.patch574 bytes

Thank you Christian for the notice :)

What a nice way to keep track on testing the standard work on modules, for sure I will have a look at your way of managing that.

I have updated the patch file

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs work » Needs review
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Thank you. Now it's looking good to me.

daniel.bosen’s picture

daniel.bosen
he/him
commented

  • chr.fritsch authored af2190d on 8.x-1.x 
    Issue #3048286 by RajabNatshah, chr.fritsch, Mohammed J. Razem: Add...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Thank you @vardot people 😀

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.