See the CR https://www.drupal.org/node/1935708

CommentFileSizeAuthor
#15 interdiff_11-15.txt278 bytesamarphule
#15 port-info-to-info-dot-yml-3048141-15.patch650 bytesamarphule
#11 port-info-to-info-dot-yml-3048141-11.patch656 bytesamarphule
#2 port-info-to-info-dot-yml-3048141-1.patch657 bytesamarphule

Comments

amarphule created an issue. See original summary.

amarphule’s picture

amarphule commented
Assigned: amarphule » Unassigned
Status: Active » Needs review
StatusFileSize
new port-info-to-info-dot-yml-3048141-1.patch657 bytes

Converted .info file into .info.yml as per CR https://www.drupal.org/node/1935708

rahul.shinde credited BramDriesen.

rahul.shinde credited ZhuRenTongKu.

rahul.shinde credited mmjvb.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented

rahul.shinde credited f2boot.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Issue tags: +#d8port
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
+++ b/hypothesis.info.yml
@@ -0,0 +1,6 @@
+description: Drupal integration with http://hypothes.is

That should be https since we're living in 2019 now :)

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented 
+++ b/hypothesis.info.yml
@@ -0,0 +1,6 @@
+package: User interface

Also not too sure this is really a User Interface thingie. Isn't this more a Content thing? No idea what the best section would be for this.

amarphule’s picture

amarphule commented
Status: Needs work » Needs review
StatusFileSize
new port-info-to-info-dot-yml-3048141-11.patch656 bytes 
@@ -0,0 +1,6 @@
+description: Drupal integration with https://hypothes.is
+configure: hypothesis.settings

I updated .info.yml file secure HTTP protocol suggested in comment #9.
As per comment #10, I am not sure whether a user interface package is the best section or not. suggest me which one is the best section for a module I will do that as of now I am keeping it as is.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented

@BramDriesen, yes we should change User Interface to Content and that makes sense to as Hypothes.is is to annotate the content.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Needs review » Needs work

Updating status.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Content would make sense indeed.

amarphule’s picture

amarphule commented
Status: Needs work » Needs review
StatusFileSize
new port-info-to-info-dot-yml-3048141-15.patch650 bytes
new interdiff_11-15.txt278 bytes

Updated .info.yml file and Attached the interdiff file

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks fine now :)

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Reviewed & tested by the community » Fixed

Patch merged into the dev branch.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Parent issue: » #3012400: [hypothesis] Hypothesis

Added parent issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.