Add AND\OR condition for dependent facets processor

The patch worked for me and seems good. I think the tests just need to be updated or something since they complain about unknown property operator: as if the object saved didn't have the data on it. Haven't looked how the facets are added in the test suite, so I'm not sure if my guess is tending in the right direction.

I tested the patch, and I have the following notes:

• There are some performance-related things that could be done, namely early exits from the loop (e.g. when the condition is TRUE and the operator is OR iterating further is not needed). Using a boolean variable instead of an array would also help with memory usage.
• The schema expects plugin.plugin_configuration.facets_processor.dependent_processor as the processor settings, operator: boolean does not conform to that. The schema needs to be updated to a mapping with operator (boolean) and facets (plugin.plugin_configuration.facets_processor.[%parent.processor_id]). This also requires an update hook for migrating the configs to the new schema.
• As mentioned above, tests need to be updated or added

Hi,

I will try to update the patch and switch to MR workflow.

Regarding comment 7.

- Config schema fixed with hook_update_N to update it.
- Existing tests fixed.
- Currently adding new ones.

I am not sure about the performance optimization, focusing on tests so this kind of refactoring will be covered.

Also realizing that tests/src/Unit/Plugin/processor/DependentFacetProcessorTest.php does not cover all the existing cases ('values').

New test added.

The patch looks good to me, but it would good to have someone confirming that it works in their setup. Especially the update hook!

@mhavelant, @kienan, @niko- could you perhaps test and review the patch (https://git.drupalcode.org/project/facets/-/merge_requests/57.diff) to push things forward here, as you reported the error or added useful information?

It would help a lot to get feedback if it's working in your setup! (And might fix your issues)

Thanks a lot in advance :)

Unfortunatley this patch needs to be adjusted to the changes introduced by #2908937: Dependend Facets don't reset after Conditions are not met anymore..

@mkalkbrenner: I am not sure how to solve the last failing test as it may be an edge case of #2908937: Dependend Facets don't reset after Conditions are not met anymore..

I attached the results of locally runned tests.

In the HTML we can see "Displaying 3 search results"

The URL is /search-api-test-fulltext?f%5B0%5D=dependingfacet%3Agrape so the depending facet is not reset.

@mkalkbrenner: I am not sure how to solve the last failing test as it may be an edge case of #2908937: Dependend Facets don't reset after Conditions are not met anymore..

It is not an edge case, you broke the feature entirely ;-)

You changed the structure of the of the conditions but you didn't adjust it in the DefaultFacetManager accordingly:

+++ b/src/FacetManager/DefaultFacetManager.php
@@ -118,7 +118,7 @@ class DefaultFacetManager {
+        foreach ($conditions['facets'] as $facet_id => $condition) {

RTBC?

Hi,

Thanks for the updated patch.

I didn't thought to look outside the plugin!

Way cleaner code by the way!

Testing locally quickly.

Hum, I have reinstalled facets after applying the patch from comment 21.

I have recorded my test as a Gif.

Two problems.

With AND: if I select a value in the depending facet and unselect a dependent facet you can see that the value is not removed in the URL and still applied.

With OR: Facet "ID" is displayed when both other facets have a value whereas it should be when one has a value.

I don't know then if tests coverage is enough.

Rerolled patch from comment #21 against version 2.0.6. Didn't test comment #25.