Closed (fixed)
Project:
Coder
Version:
8.x-3.x-dev
Component:
Coder Sniffer
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Apr 2019 at 09:07 UTC
Updated:
18 Jan 2020 at 18:29 UTC
Jump to comment: Most recent
Drupal core is dropping PHP 5 support, see https://www.drupal.org/node/2938726 . I think we should do the same in Coder 8.3.x.
* Users running older PHP versions can still use Coder 8.3.1 or an earlier version.
* I think it is not worth it to bump Coder to version 9 just for dropping old PHP versions. That would just be more maintenance work.
* The new minimum requirement would be PHP 7.0
Comments
Comment #2
klausiPull request: https://github.com/pfrenssen/coder/pull/25
Comment #3
truls1502I am agreed with him. So I think it would be good that the coder module can also help and push the developer to using the latest stable version.
Comment #4
klausiThought about this some more and read up on Drupal core's policy in #2992116: Bump core dependencies minimum version to PHP 7.0.
* Active PHP 5 support will be dropped with 8.7.0 but core tests will still be run on PHP 5.
* Hard breaks with PHP 5 will start in 8.8.0.
* Coder is part of the testing infrastructure, so we also need to support PHP 5
* Drupal 8 core requires a minimum of PHP 5.5, so we could at least drop PHP 5.4 support
* DrupalCI also supports Coder checking on PHP 5.3 for Drupal 7 projects. I have no idea why that even works, because even Coder 8.x-2.x requires PHP 5.4.
Given that I think we can drop PHP 5.4 support for now and postpone dropping PHP 5 until Drupal core 8.8.0 is released.
Comment #5
truls1502It sounds a sense plan :)
Comment #8
klausiDrupal 8.8 was released, dropped PHP 5 support now.
New minimum requirement is now the same as Drupal core has, 7.0.8.