There are multiple instances where we face challenges with the PDF Engine being used. We need the flexibility to choose different PDF engines and run them in parallel.

Implementation:

  • The change applies to entity type node and export type PDF
  • Define Content type specific setting in entity print settings page
  • The EntityPrint controller will Chose the plugin instance based on the content type PDF engine setting
  • if the content type specific PDF engine is not set. it will fallback to Entity print settings PDF engine

image_one
image_two

CommentFileSizeAuthor
#13 entity_print-ct_pdf_engine-3047040-13.patch6.75 KBameymudras
#9 entity_print-ct_pdf_engine-3047040-9.patch6.8 KBrakshith.thotada
#6 ct_edit_page_one.png188.41 KBrakshith.thotada
#6 ct_edit_page_two.png164.74 KBrakshith.thotada
#3 entity_print-ct_pdf_engine-3047040-3.patch5.74 KBrakshith.thotada

Comments

rakshith.thotada created an issue. See original summary.

rakshith.thotada’s picture

rakshith.thotada commented
Title: Provide option to chose PDF engines based on Content type » Provide option to choose PDF engines based on Content type
Issue summary: View changes
rakshith.thotada’s picture

rakshith.thotada commented
StatusFileSize
new entity_print-ct_pdf_engine-3047040-3.patch5.74 KB

Patch to cover all the above implementation details.

rakshith.thotada’s picture

rakshith.thotada commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: entity_print-ct_pdf_engine-3047040-3.patch, failed testing. View results

rakshith.thotada’s picture

rakshith.thotada commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new ct_edit_page_two.png164.74 KB
new ct_edit_page_one.png188.41 KB

Status: Needs review » Needs work

The last submitted patch, 3: entity_print-ct_pdf_engine-3047040-3.patch, failed testing. View results

rakshith.thotada’s picture

rakshith.thotada commented
Status: Needs work » Needs review
rakshith.thotada’s picture

rakshith.thotada commented
Issue summary: View changes
StatusFileSize
new entity_print-ct_pdf_engine-3047040-9.patch6.8 KB

Status: Needs review » Needs work

The last submitted patch, 9: entity_print-ct_pdf_engine-3047040-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

rakshith.thotada’s picture

rakshith.thotada commented
Issue summary: View changes
rakshith.thotada’s picture

rakshith.thotada commented
Status: Needs work » Needs review
ameymudras’s picture

ameymudras commented
StatusFileSize
new entity_print-ct_pdf_engine-3047040-13.patch6.75 KB

I noticed that there are dompdf warnings thrown which clog up the watchdog, adding a setting which will help us disable the watch dog exceptions when needed.

jernejbeg’s picture

jernejbeg commented
Status: Needs review » Reviewed & tested by the community

entity_print-ct_pdf_engine-3047040-13.patch works as described. Thank you for your work.

benjy’s picture

benjy commented
Status: Reviewed & tested by the community » Needs work

Any new features that are added are going to need to be supported by all entity types, if that isn't the case i'd suggest another module such as entity_print_node which can add additional node specific features