Problem/Motivation

In #3046855: Notify site administrators when new PSA is posted we are adding the ability to email admins. Depending on when things land, we might want to add a UI config option to enable/disable the emailing. But definitely we want a kill switch for PSAs overall. So we don't annoy the random folks who want to disable that feature. Or, more likely, when that service lands in core and we want to disable it from config so we don't send duplicate messaging.

Proposed resolution

Add a kill switch to the service. Optionally (depending on the order of things if #3046855: Notify site administrators when new PSA is posted lands first, add a UI element to disable sending emails.

Remaining tasks

Do it.

User interface changes

API changes

Data model changes

Release notes snippet

Comments

heddn created an issue. See original summary.

heddn’s picture

Status: Active » Needs review
StatusFileSize
new3.98 KB
heddn’s picture

StatusFileSize
new4.96 KB

  • heddn committed 3b47743 on 8.x-1.x
    Issue #3046858 by heddn: Add admin / config page to enable/disable PSA
    
heddn’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work
Issue tags: -Needs backport to D7
tatarbj’s picture

Issue tags: +DrupalCampBelarus2019
tatarbj’s picture

Issue tags: +dckyiv2019
tatarbj’s picture

Assigned: Unassigned » tatarbj

I'm on it to backport to D7

tatarbj’s picture

Status: Needs work » Needs review
StatusFileSize
new2.81 KB

Functionality and its test coverage are backported to D7.

heddn’s picture

Status: Needs review » Needs work

Looks like the tests didn't pass?

tatarbj’s picture

Status: Needs work » Needs review
Issue tags: +DC19PL
StatusFileSize
new2.89 KB

Right. I've checked it now, also cleaned up the coding standards issues and adjusted the tests.

tatarbj’s picture

Status: Needs review » Needs work

still no good, i continue adapting the tests.

heddn’s picture

Status: Needs work » Needs review
StatusFileSize
new4.14 KB
new2.97 KB
heddn’s picture

StatusFileSize
new3.4 KB
new5.37 KB

  • heddn committed 4196d19 on 7.x-1.x
    Issue #3046858 by heddn, tatarbj: Add admin / config page to enable/...
heddn’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.