Looking at other CKEditor plugin modules and some of the documentation on drupal.org, it seems to be a defacto standard to have ckeditor plugins in libraries/ckeditor/plugins/pluginname.
This makes sense since it removes the risk of confusion and conflicts with non-ckeditor libraries that might have the same name and CKEditor's default instructions are to put plugins in a plugins sub-directory, which is what Drupal core does with its default CKEditor plugins.
If we can get consistency with where CKEditor plugin modules store their libraries it also makes it easier to manage all CKEditor plugins in a uniform manner.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3046772-7.patch | 1.05 KB | Webbeh |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
Webbeh+1 to this request.
Comment #3
WebbehConsolidating similar issues into this, so we have one issue to do the work on this:
We will want to reconcile this issue and #3104018: Support library auto install via composer in asset dir, which placed composer configuration to the library into the dev branch.
Additionally, #3103870: Follow core and contrib conventions for the location of plugin.js has started work on a patch to accomplish the issue outlined here. As this issue is older, I'm hoping to merge these so we can have some cohesive communication and movement on this issue.
Comment #4
WebbehComment #5
WebbehCan you link to any projects or issues where this has been done?
I am curious how this aligns with composer installs, now that we've crossed the bridge on how to automate the dependency management with composer through #3104018: Support library auto install via composer in asset dir.
Comment #6
WebbehUpdating this to note that this issue should build off of the work of #3051639: Warning: file_get_contents(/libraries/font/plugin.js): failed to open stream: No such file or directory in _locale_parse_js_file() (line 1130 of core/modules/locale/locale.module). once committed.
Comment #7
WebbehFor review.
I placed the logic for
libraries/ckeditor/pluginsoutside of the initial search array to reduce the extraneous usage offile_exists()in typical installs, placing it at the end.Comment #8
WebbehWell, since this never got touched in 2 years, I'm going to go ahead and commit this, to allow the edge-case of folks installing in that location to leverage this. I'll roll out this into a new version alongside #3290833: 8.x-1.3 release plan.
Comment #11
WebbehY'all - better late than never. Thanks for your patience on this.