Closed (fixed)
Project:
Mail System
Version:
8.x-4.x-dev
Component:
Module compatibility
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Apr 2019 at 15:58 UTC
Updated:
19 Nov 2019 at 23:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
manuel garcia commentedHere is a start.
Comment #4
manuel garcia commentedComment #5
manuel garcia commentedComment #6
manuel garcia commentedComment #7
berdircore is in the process of changing this to protected, you should be able to do that already.
the as drupalX use statements are for BC, to use the old method names, if you include this yourself, I'd just update the method calls and just do use AssertMailTrait;
Those are just nitpicks, looks fine I think.
Comment #8
thallesI do not know if I understood correctly, would that be?
Comment #9
berdirI think so, the interdiff is somehow broken, so a bit hard to review, but the use and public/protected is changed.
Comment #10
manuel garcia commentedChanges look good, and make sense - thanks both for the review and follow up. Here's the correct interdiff.
Comment #12
manuel garcia commentedComment #14
david radcliffe commented