Problem/Motivation

Currently we're using simpletest, which is being phased out by the PHPUnit initiative.

Proposed resolution

Convert them to PHPUnit.

Remaining tasks

Do it.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

Comments

Manuel Garcia created an issue. See original summary.

manuel garcia’s picture

Status: Active » Needs review
StatusFileSize
new2.33 KB

Here is a start.

Status: Needs review » Needs work

The last submitted patch, 2: 3046621-2.patch, failed testing. View results

manuel garcia’s picture

Status: Needs work » Needs review
StatusFileSize
new12.08 KB
new13.57 KB
manuel garcia’s picture

manuel garcia’s picture

Issue tags: +Drupal 9 compatibility
berdir’s picture

Status: Needs review » Reviewed & tested by the community
  1. +++ b/tests/src/Functional/AdminFormSettingsTest.php
    @@ -1,29 +1,26 @@
        */
    -  public static $modules = [
    -    'mailsystem'
    -  ];
    +  public static $modules = ['mailsystem'];
    

    core is in the process of changing this to protected, you should be able to do that already.

  2. +++ b/tests/src/Functional/MailsystemTestThemeTest.php
    @@ -1,15 +1,19 @@
    +class MailsystemTestThemeTest extends BrowserTestBase {
    +  use AssertMailTrait {
    +    getMails as drupalGetMails;
    +  }
     
    

    the as drupalX use statements are for BC, to use the old method names, if you include this yourself, I'd just update the method calls and just do use AssertMailTrait;

Those are just nitpicks, looks fine I think.

thalles’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new14.27 KB
new1.67 KB

I do not know if I understood correctly, would that be?

berdir’s picture

I think so, the interdiff is somehow broken, so a bit hard to review, but the use and public/protected is changed.

manuel garcia’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new1.93 KB

Changes look good, and make sense - thanks both for the review and follow up. Here's the correct interdiff.

  • Manuel Garcia committed 6dcd1cf on 8.x-4.x
    Issue #3046621 by Manuel Garcia, thalles, Berdir: Convert tests to...
manuel garcia’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

david radcliffe’s picture

Issue summary: View changes