https://github.com/mcdwayne/Drupal-9-drupal-check-Report/blob/master/Dru...

drupal-check results on commit hash: 
source   : [git] https://git.drupal.org/project/tfa ceebf0410ccc382412918145208d42619713eb51
source : http://cgit.drupalcode.org/tfa 
 ------ ------------------------------------------------------------------------- 
  Line   src/Commands/TfaCommands.php                                             
 ------ ------------------------------------------------------------------------- 
  26     Call to deprecated function db_query():                                  
         in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,               
         get a database connection injected into your service from the container  
         and call query() on it. For example,                                     
 ------ ------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Form/TfaLoginForm.php                                                          
 ------ ----------------------------------------------------------------------------------- 
  118    Call to deprecated method getStorage() of class Drupal\Core\Entity\EntityManager:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                  
         Use \Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() instead.          
 ------ ----------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Block/TfaUserLoginBlock.php                                                                                           
 ------ --------------------------------------------------------------------------------------------------------------------------------- 
  91     Call to deprecated constant USER_REGISTER_ADMINISTRATORS_ONLY: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use  
         \Drupal\user\UserInterface::REGISTER_ADMINISTRATORS_ONLY instead.                                                                
  92     Call to deprecated method l() of class Drupal:                                                                                   
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                                                                            
         \Drupal\Core\Link::fromTextAndUrl() instead.                                                                                     
  99     Call to deprecated method l() of class Drupal:                                                                                   
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                                                                            
         \Drupal\Core\Link::fromTextAndUrl() instead.                                                                                     
 ------ --------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------- 
  Line   src/Plugin/EncryptionMethod/McryptAES128Encryption.php                         
 ------ ------------------------------------------------------------------------------- 
  32     Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:  
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                          
         mb_substr() instead.                                                           
  56     Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:  
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                          
         mb_substr() instead.                                                           
 ------ ------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Plugin/TfaLogin/TfaTrustedBrowser.php                                         
 ------ ---------------------------------------------------------------------------------- 
  119    Call to deprecated method randomBytes() of class Drupal\Component\Utility\Crypt:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                 
         Use PHP's built-in random_bytes() function instead.                               
 ------ ---------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/TfaRandomTrait.php (in context of class Drupal\tfa\Plugin\TfaValidation\TfaRecoveryCode)  
 ------ ---------------------------------------------------------------------------------------------- 
  82     Call to deprecated method randomBytes() of class Drupal\Component\Utility\Crypt:              
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                             
         Use PHP's built-in random_bytes() function instead.                                           
 ------ ---------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 9 errors
CommentFileSizeAuthor
#14 3046504-14.patch10.7 KBjcnventura
#14 interdiff-3046504-13-14.txt3.98 KBjcnventura
#13 interdiff-3046504-10-13.txt432 bytesacbramley
#13 3046504-13.patch6.94 KBacbramley
#10 3046504-10.patch6.96 KBdpi
#10 interdiff-3046504-9-10.patch338 bytesdpi
#9 3046504-9.patch6.5 KBjcnventura
#9 interdiff.txt681 bytesjcnventura
#8 interdiff.txt3 KBjcnventura
#7 3046504-7.patch5.71 KBjcnventura
#7 interdiff.txt6.66 KBjcnventura
#6 drupal9_readiness-3046504-6.patch2.68 KBvatsalkhanna
#5 3046504-5.patch9.35 KBmanuel garcia
#5 interdiff-3046504-3-5.txt4.83 KBmanuel garcia
#3 3046504-3.patch9.33 KBmanuel garcia

Comments

Manuel Garcia created an issue. See original summary.

manuel garcia’s picture

manuel garcia commented 
------ ------------------------------------------------------------------------ 
  Line   services_tfa/src/Plugin/ServiceDefinition/GenericValidation.php         
 ------ ------------------------------------------------------------------------ 
         Class Drupal\services\ServiceDefinitionBase not found and could not be  
         autoloaded.                                                             
 ------ ------------------------------------------------------------------------

This looks to me like a false positive.

manuel garcia’s picture

manuel garcia commented
Status: Active » Needs review
StatusFileSize
new 3046504-3.patch9.33 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3046504-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

manuel garcia’s picture

manuel garcia commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3046504-3-5.txt4.83 KB
new 3046504-5.patch9.35 KB
vatsalkhanna’s picture

vatsalkhanna commented
Version: 8.x-1.x-dev » 8.x-1.0-alpha4
StatusFileSize
new drupal9_readiness-3046504-6.patch2.68 KB

drupal-check on 8.x-1.0-alpha4

 ------ ------------------------------------------------------------------------------------ 
  Line   services_tfa/src/Plugin/ServiceDefinition/GenericValidation.php                     
 ------ ------------------------------------------------------------------------------------ 
         Class Drupal\services\ServiceDefinitionBase not found and could not be autoloaded.  
         💡 Learn more at https://phpstan.org/user-guide/autoloading                          
  30     Class Drupal\services\ServiceDefinitionBase not found and could not be autoloaded.  
         💡 Learn more at https://phpstan.org/user-guide/autoloading                          
 ------ ------------------------------------------------------------------------------------ 
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/TfaLoginForm.php                                             
 ------ ---------------------------------------------------------------------- 
  228    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
 ------ ---------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Block/TfaUserLoginBlock.php                                                                         
 ------ --------------------------------------------------------------------------------------------------------------- 
  93     Call to deprecated constant USER_REGISTER_ADMINISTRATORS_ONLY: Deprecated in drupal:8.3.0 and is removed from  
         drupal:9.0.0. Use \Drupal\user\UserInterface::REGISTER_ADMINISTRATORS_ONLY instead.                            
  94     Call to deprecated method l() of class Drupal:                                                                 
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                                                          
         \Drupal\Core\Link::fromTextAndUrl() instead.                                                                   
  101    Call to deprecated method l() of class Drupal:                                                                 
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                                                          
         \Drupal\Core\Link::fromTextAndUrl() instead.                                                                   
 ------ --------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Plugin/TfaLogin/TfaTrustedBrowser.php                                         
 ------ ---------------------------------------------------------------------------------- 
  118    Call to deprecated method randomBytes() of class Drupal\Component\Utility\Crypt:  
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                 
         Use PHP's built-in random_bytes() function instead.                               
 ------ ---------------------------------------------------------------------------------- 


 [ERROR] Found 7 errors
jcnventura’s picture

jcnventura
Primary language English
commented
Issue summary: View changes
StatusFileSize
new interdiff.txt6.66 KB
new 3046504-7.patch5.71 KB

I'm removing the 2 errors usually reported in the services_tfa when the services module is not available.

Not sure what #6 was trying to achieve, as it was a considerably less complete than #5, so I'm only doing an interdiff to #5. Many of the changes in #5 are already in the module as part of #2924691: Remove fallback plugins, make recovery code concept into validation & setup plugins.

jcnventura’s picture

jcnventura
Primary language English
commented
StatusFileSize
new interdiff.txt3 KB

Proper interdiff, as the previous one seemed to imply a lot of drupal_set_message rollbacks.

jcnventura’s picture

jcnventura
Primary language English
commented
StatusFileSize
new interdiff.txt681 bytes
new 3046504-9.patch6.5 KB

It seems after all this, the patch was still missing the core_version_requirement: ^8 || ^9 key in both the tfa and services_tfa modules.

Adding those now.

dpi’s picture

dpi
Location Perth, Australia
commented
Version: 8.x-1.0-alpha4 » 8.x-1.x-dev
StatusFileSize
new interdiff-3046504-9-10.patch338 bytes
new 3046504-10.patch6.96 KB

Fixes missing core_version_requirement for tfa_test_plugins submodule.

jcnventura’s picture

jcnventura
Primary language English
commented

Not sure if the change in #10 is needed or even desired.

It might be that this module should be in the 'Testing' package. And modules in the 'Testing' package should not add this property as specified in https://www.drupal.org/node/3070687

meet_bhanvadia’s picture

meet_bhanvadia commented

Hi all,

Patch at #10 works fine for me.

acbramley’s picture

acbramley commented
StatusFileSize
new 3046504-13.patch6.94 KB
new interdiff-3046504-10-13.txt432 bytes

As per #11 we can just use the Testing package.

jcnventura’s picture

jcnventura
Primary language English
commented
StatusFileSize
new interdiff-3046504-13-14.txt3.98 KB
new 3046504-14.patch10.7 KB

Adding some changes from the rector-generated patch over in #3149047: Automated Drupal 9 compatibility fixes.

  • jcnventura authored cc9d5fc on 8.x-1.x 
    Issue #3046504 by jcnventura, Manuel Garcia, dpi, acbramley,...
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed
acbramley’s picture

acbramley commented

Thank you @jcnventura! Any chance we can get a new release for this?

Belhendo’s picture

Belhendo commented

Hi all,

I'm the Product Owner at GovCMS, I'm wondering if there is a roadmap/draft timeline for D9 readiness for the TFA module please?

Thanks!

jcnventura’s picture

jcnventura
Primary language English
commented

@belhendo, the roadmap is here (#2925358: Two-factor Authentication (TFA) 1.0.0 stable release plan), but it needs to be updated. It will be soon, but it will still be an alpha. Please comment on that issue.

Belhendo’s picture

Belhendo commented

Thanks @jcnventura!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.