Problem/Motivation

Follow-up from #3029800-3: Fix disabled vertical margin collapsing for hidden title webform:

This also affects webform flexbox in nested flexbox layouts.

In webform.element.flexbox.css .form-item's margin is reset.

This is becoming a problem and we need to fix it.

CommentFileSizeAuthor
#4 webform-element-flexbox-bottom-margin-reset-problem-3045912-4.patch2.84 KBpivica
#4 interdiff-3045912-3-4.txt1.05 KBpivica
#3 interdiff-3045912-2-3.txt841 bytespivica
#3 webform-element-flexbox-bottom-margin-reset-problem-3045912-3.patch2.66 KBpivica
#2 webform-element-flexbox-bottom-margin-reset-problem-3045912-2.patch2.12 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Issue tags: +next-release
StatusFileSize
new webform-element-flexbox-bottom-margin-reset-problem-3045912-2.patch2.12 KB

Here is a patch.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new webform-element-flexbox-bottom-margin-reset-problem-3045912-3.patch2.66 KB
new interdiff-3045912-2-3.txt841 bytes

Found some additional problems while trying to improve this:

- We are adding a margin-top to form-actions. This is not consistent with a general Bootstrap guideline that we should set only bottom margin to elements, and this can also create regressions and unexpected behaviours.
- Captcha element is not using form-group and form-item classes. This was probably a reason why we added margin-top to form actions in the first place.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3045912-3-4.txt1.05 KB
new webform-element-flexbox-bottom-margin-reset-problem-3045912-4.patch2.84 KB

Improved bottom margin reset.

  • pivica committed 9007ab6 on 8.x-1.x 
    Issue #3045912 by pivica: Webform element flexbox css resetting bottom...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.