Problem

From a customer

I have discovered that the wording on the buttons when an AN tries to enroll in an event can be confusing. Some people interpret "Sign up" to mean sign up for the event rather than sign up for Open Social, and members who have accounts have encountered difficulty by clicking that option.

What do you think about changing the design to have buttons that say something like "Create an Account" "Log In" "Enroll as a Guest" and removing the "Enroll with account" and "Enroll without account" headings?

Solution

Change "Sign up" in the modal to "Create an account" and change "Sign up as guest" to "Enroll as guest".

As discussed with Xinyu and Natasha:

I think the problem is the sign up button. I agree that we should change the 'sign up' button into 'Create an account'.

I don't think we should remove the headings though, they are used to categorise these 2 options conceptually.

  • Create an account
  • Log in
  • Enroll as guest
CommentFileSizeAuthor
#6 after_patch-3045772-6.PNG8.76 KBAkanksha92
#4 3045772-3.patch1.61 KBkavbiswa

Comments

Kingdutch created an issue. See original summary.

Akanksha92’s picture

Akanksha92 commented
Assigned: Unassigned » Akanksha92
kavbiswa’s picture

kavbiswa commented
Assigned: Akanksha92 » kavbiswa
kavbiswa’s picture

kavbiswa commented
Assigned: kavbiswa » Unassigned
Status: Active » Needs review
StatusFileSize
new 3045772-3.patch1.61 KB

Please find the attached patch.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Changes look good to me : ) Thanks!

Akanksha92’s picture

Akanksha92 commented
StatusFileSize
new after_patch-3045772-6.PNG8.76 KB

@kavbiswa the patch looks good. The patch applied to the module successfully. Please find the attached screenshot for the same.

kavbiswa’s picture

kavbiswa commented

Thanks for the review :)

Can you please give the fix credits ?

jaapjan’s picture

jaapjan commented
Status: Reviewed & tested by the community » Fixed

Will be in 5.x. You'll get the credits after it is released.

kavbiswa’s picture

kavbiswa commented

Thanks @jaapjan

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Fixed » Reviewed & tested by the community

Hi Kavbiswa,

Just some post merge feedback for future improvements to patches that I didn't come around to before :)

In Open Social we test using Behat. It's usually useful to check for texts that are changed in a ticket to also check if they appear in the Behat tests. If you don't know how to alter them there then you can leave a note in the ticket that some more work is needed. In this case I changed the tests after the ticket.

When you create a patch, be sure to create it from the root of the module or distribution. In this case your patch was made from your web root. This means that automated tools will not be able to apply it. You can see this by the patch containing profiles/social in the file paths. In this case the social folder would be the root so you'd have to end up with only modules/social_features/social_event/modules/social_event_an_enroll/templates/event-an-enroll-dialog.html.twig as file path (from inside the social folder).

Thanks for your contribution!

~ Kingdutch

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Silly browser, changing the status.

kavbiswa’s picture

kavbiswa commented

Thanks @Kingducth for the inputs

  • ab470ca committed on 8.x-5.x 
    Issue #3045772 by Kingdutch, jaapjan, kavbiswa, Akanksha92: Alter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.