There's a typo in the description text for the "Multiple subscriptions" options on the configuration form at admin/config/services/recurly. It says:

Single-plan mode allows users are only one subscription at a time, preventing them from having multiple plans active at the same time. If users are allowed to sign up for more than one subscription, use Multiple-plan mode.

I think it would read better if it said something like, "Single-plan mode allows user only one subscription at a time ..."

CommentFileSizeAuthor
#14 description_text-3045678-14.patch1.04 KBjohnny5th
#8 Screen Shot 2019-08-02 at 1.05.11 PM.png55.31 KBalonaoneill
#7 description_text-3045678-7.patch1.02 KBsergiu stici
#5 Screen Shot 2019-08-01 at 2.24.46 PM.png33.66 KBalonaoneill
#4 description_text-3045678-4.patch1021 bytessergiu stici

Comments

eojthebrave created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Makes sense. Patches welcome!

Revathi Manohar’s picture

Revathi Manohar commented
Assigned: Unassigned » Revathi Manohar
sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new description_text-3045678-4.patch1021 bytes

Here is the patch, please review.

alonaoneill’s picture

alonaoneill commented
Assigned: Revathi Manohar » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-08-01 at 2.24.46 PM.png33.66 KB

Looks good to me. Patch applied.
Typo was fixed. Added screen.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

It's now grammatically correct, but still doesn't flow nicely. How about something like:

Single-plan mode allows each user only one subscription at a time, preventing him/her from having multiple plans active simultaneously. Use Multiple-plan mode if each user is allowed to sign up for more than one subscription at the same time.

sergiu stici’s picture

sergiu stici commented
Status: Needs work » Needs review
StatusFileSize
new description_text-3045678-7.patch1.02 KB
alonaoneill’s picture

alonaoneill commented
StatusFileSize
new Screen Shot 2019-08-02 at 1.05.11 PM.png55.31 KB

Patch applied. Added screen.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented

Maybe instead of "him/her" would could just make it gender agnostic like "them", or "the user". This would make the language more inclusive.

alonaoneill’s picture

alonaoneill commented

I think "the user" doesn't sound good: "Single-plan mode allows each user only one subscription at a time, preventing the user having multiple plans active simultaneously."
Maybe "them" would be better.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

So how about this?

Single-plan mode allows users only one subscription at a time, preventing them from having multiple plans active simultaneously. Use Multiple-plan mode if each user is allowed to sign up for more than one subscription at the same time.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented

👍

alonaoneill’s picture

alonaoneill commented

Yes "them" sounds good to me!
@eojthebrave good catch!

johnny5th’s picture

johnny5th commented
StatusFileSize
new description_text-3045678-14.patch1.04 KB

Sounds good to me. Created a patch.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Thanks.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 8.x-1.x-dev » 4.x-dev

  • colan committed 3c36096 on 4.x 
    Issue #3045678 by Sergiu Stici, johnny5th, alonaoneill, eojthebrave,...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.