Problem/Motivation

When errors occur during the minification of JS, the errors are logged. It would be useful to see in which file the error occurs, so developers are able to fix this if possible.

Proposed resolution

Add the file path to the log message.

Remaining tasks

Write patch
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#11 Add_path_when_logging_errors_in_JS_minification-3045457-11-D8.patch3.96 KBthalles
#9 interdiff-2-9.txt1.35 KBthalles
#9 Add_path_when_logging_errors_in_JS_minification-3045457-9-D8.patch3.95 KBthalles
#7 Add_path_when_logging_errors_in_JS_minification-3045457-7-D8.patch3.02 KBthalles
#2 3045457-2.patch2.63 KBseanb

Comments

seanB created an issue. See original summary.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
StatusFileSize
new 3045457-2.patch2.63 KB

Patch is attached.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Active » Needs review
askibinski’s picture

askibinski commented
Status: Needs review » Reviewed & tested by the community

Very helpful debugging information.
Patch looks good, applies cleanly and works as designed. Tested it with broken js to trigger the log entry.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Looks good!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Needs work
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new Add_path_when_logging_errors_in_JS_minification-3045457-7-D8.patch3.02 KB

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new Add_path_when_logging_errors_in_JS_minification-3045457-9-D8.patch3.95 KB
new interdiff-2-9.txt1.35 KB

New!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Needs work

Needs refactor the test CssMinifierUnitTest

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new Add_path_when_logging_errors_in_JS_minification-3045457-11-D8.patch3.96 KB

  • thalles committed f5579d8 on 8.x-4.x 
    Issue #3045457 by thalles, seanB: Add path when logging errors in JS...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Fixed

Fixed, great feature!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.