CommentFileSizeAuthor
#3 deprecations-86-3045296-3.patch2.28 KBBerdir
#2 deprecations-86-3045296-2.patch1.97 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Remove deprecated code for 8.6 and older. » Remove deprecated code for 8.6 and older
FileSize
deprecations-86-3045296-2.patch1.97 KB

WIP, this isn't very helpful until ctools updates the usage as well.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
deprecations-86-3045296-3.patch2.28 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

The context stuff is now happening in #3045296: Remove deprecated code for 8.6 and older but includes 8.7 changes. still need the installSchema() change, could maybe just do that here.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

I think we should go with the current patch and leave only the 8.7 stuff (context_definitions) for #3004108: ContextDefinition object for an entity type is deprecated.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Yeah, probably makes sense, although I'm fine with updating the core dependency on 8.7 after the next release, so we can do that over there.

  • Berdir committed 236ef20 on 8.x-1.x 
    Issue #3045296 by Berdir: Remove deprecated code for 8.6 and older

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.