Allow a poll to be unpublished

This functionality works for me in my project with Drupal version 8.6.16 without applying this patch.

Thanks,
Rasika P

There will be many times where you want the results of a closed poll to be visible. This probably needs to be an option on a per poll basis and not based on permissions.

Closed poll: visible, but not voteable.

The issue of some drupal sites wanting to show the final result is a tricky one that isnt considered in the patch.

Where are you seeing the poll that you dont like?

If it is in a listing, maybe there should be (or is?) a iews option to not list closed polls?

If it is for the poll itself etc, then the options need to consider a lot more - you will often want the result of a closed poll to be visible.

@Berdir, @BramDriesen, what do you think about it?

I think it makes more sense to allow a poll to be unpublished similar to a regular entity/node. A closed poll should still be accessible to show the results in many/most cases.

Hi @BramDriesen,

The "published" = "status" (entity_keys) is already exists as Active(A flag indicating whether the poll is active.) Field,

this Active filed is used to open or close any poll, I guess we have to introduce new filed for open or close any poll, and will use this field to publish or unpublished any poll.

Please confirm.

Thanks
Samit K.

Some extra things that came to mind:

- Needs update hook to update all existing polls to copy over the value from what is now published to the new Active field. Probably best to also set "published" to TRUE as default for now. (needs to be a batch!)
- Update view
- Update list builder

Can already be tested. Only needs to add some tests for this.

I tested it manually:

1) I created a new poll with anonymous votes. Poll is active and published.
2) Anonymous user can view poll and can vote
3) I set active=false, Anonymous user can view poll and can't vote
4) I set active=true and published=false
5) Anonymous user can't view poll

It works as expected.

But, after I set poll published=false, poll hide from Poll List Builder.

Proposed solution:

1) Allow to view unpublished polls into List Builder
2) We can also add new column "status" as Node List Builder with publishing status

The list builder I must admit I did not test yet! Thanks for the manual review :-) really helps

@Bram, do you have time to continue this issue? It looks like 90% ready :)

Poll list viewer seems to work fine.

Did notice in the listbuilder class that the votes section is not implemented. Will create a follow up issue for that.

Looks like MR needs reroll 🤔

All green now :-)

I will test it now :)

Re #19: #3479810: PollListBuilder is missing vote information

Existing sites don't have new "status" field in /admin/content/poll, because they have "old" poll admin view. Should we add in hook_update re-import views.view.poll_admin.yml config form poll config/install directory?

That has crossed my mind as well. Not sure how to deal with that, as sites might have overwritten the view.

Or we can write about it in release notes

I think a change records makes sense. Will draft it here: https://www.drupal.org/node/3479831

Done 👆

Also added the view related info in the CR.

Thanks for your reviews! @ivnish. Thanks to the rest that participated!